Skip to content

Conversation

@jezdez
Copy link
Member

@jezdez jezdez commented May 2, 2023

  • remove support for Django 2.2
  • remove support for Django 4.0
  • add support for Django 4.2
  • add support for Python 3.11 on supported Django versions

jezdez added 3 commits May 2, 2023 10:42
- remove support for Django 2.2
- remove support for Django 4.0
- add support for Django 4.2
- add support for Python 3.11 on supported Django versions
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.49%. Comparing base (6e367cd) to head (952f729).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   94.49%   94.49%           
=======================================
  Files          31       31           
  Lines        1344     1344           
=======================================
  Hits         1270     1270           
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cache: 'pip' # caching pip dependencies

- name: Install dependencies
run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also skip the Pip version check, relying on GitHub to ship a fairly recent, continuously updated version. E.g.

python -m pip install tox-gh-actions wheel --disable-pip-version-check

@bittner bittner changed the title Update CI setup. Update CI setup May 2, 2023
@jezdez jezdez marked this pull request as draft May 2, 2023 08:49
django-version:
- '2.2'
- '3.2'
- '4.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the version numbers here, too!

- { django-version: '4.0', python-version: '3.7' }
- { django-version: '4.1', python-version: '3.7' }
- { django-version: '4.2', python-version: '3.7' }
- { django-version: '3.2', python-version: '3.11' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to exclude Python 3.6 for Django 4.1 and 4.2, too!

In addition, Django 3.2 doesn't officially support Python 3.11.

Copy link
Member

@bittner bittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to be finished and merged.

python-django:
runs-on: ubuntu-latest
test:
runs-on: ubuntu-20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: ubuntu-20.04
runs-on: ubuntu-latest

We should simply drop Python 3.6 support. GitHub's VMs for GHA have stopped shipping unsupported Python versions. That makes things difficult.

@bittner
Copy link
Member

bittner commented Dec 20, 2024

@jezdez Do you want to push this forward? A full overhaul would be overdue in any case.

@bittner
Copy link
Member

bittner commented Apr 4, 2025

I opened PR #233 to unblock all PRs that are currently blocked by our outdated CI setup.

Closing this PR as obsolete/outdated. Feel free to reopen or reuse or suggest parts of your changes in my PR.

@bittner bittner closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants