Migrate to pyproject.toml, use Ruff, update GHA setup #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bittner
force-pushed
the
feature/update-gha-checks-and-testmatrix
branch
from
87b2ab1 to
80df645
Compare
This was referenced Apr 4, 2025
Closed
Closed
Member
Author
|
Happy seasonal greetings! 🐰 🪺 🥚 Review this code, anyone? – If you review the commits separately it should be a quick thing to do. Thanks! |
Member
Author
|
Hello @jazzband! - Someone, please review! 📣 |
Member
Author
matthiask
approved these changes
Jul 8, 2025
Member
matthiask
left a comment
matthiask
left a comment
There was a problem hiding this comment.
It's a lot and I havent read everything. The parts which I've read closely look good to me.
(Yep, requiring reviews is bad, but not requiring them isn't good either.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the packaging setup to
pyproject.toml, finally, and updates the CI setup (GHA) targeting the currently latest Django versions and their related Python versions.type="text/javascript"attribute from all script HTML tags for JavaScript. (This change is not strictly necessary for this PR and can be omitted if requested; it's included for convenience.)Note that all authors are now listed in
pyproject.toml; we now might remove the AUTHORS.rst file.I suggest to keep the commits intact and refrain from squashing.
Obsoletes #227, #229 and #230.