fix(scripts): serve grpc for a web viewer#2881
fix(scripts): serve grpc for a web viewer#2881sotanakamura wants to merge 2 commits intohuggingface:mainfrom
Conversation
|
Hi @sotanakamura, We (@imstevenpmwork) refactored our rerun visualizer to correctly support distant viewers (fbe4c8b). The implementation differs from your PR but it should solve the issue. I'm closing this PR, but feel free to open a new one if you spot another issue ! Best, Caroline. |
|
This problem has not been solved yet in the latest code. Please run the command to reproduce the bug. Access to http://localhost:9090/?url=rerun%2Bhttp%3A%2F%2Flocalhost%3A9876%2Fproxy |
|
You're right, sorry ! I re-opened the PR and will try it asap - Thanks for notifying me. |
|
Hi @sotanakamura, This PR indeed solves the issue, again sorry for the early deletion. Before merging it, could you change Best, Caroline. |
|
Duplicate of #2534 |
|
Thank you for reviewing my PR. I found that opening a web viewer in a remote machine dose not work well. Instead of that, I added command line output to show the web viewer URI. I also fixed the following problems:
|
|
Thank you for the additions ! Deprecating websockets was the next item in my TODO 👍 Though I'm not 100% sure the way you recover the distant machine IP will be robust on all setups... I think you can safely ask the user to provide the distant machine IP in the URL, or to use ssh forwarding as we did for websockets (c.f. file header). Also to avoid syntax errors on the URL, you can stick to the |
Type / Scope
Summary / Motivation
Serving grpc is necessary to visualize data in the distant mode.
Related issues
fix #2898
What changed
Serve grpc and pass its uri to the web viewer.
How was this tested (or how to run locally)
Run the lerobot_dataset_viz as follows:
Access to http://localhost:9090/?url=rerun%2Bhttp%3A%2F%2Flocalhost%3A9876%2Fproxy
Checklist (required before merge)
pre-commit run -a)pytest)Reviewer notes