Conversation
StaszkeKun
left a comment
StaszkeKun
left a comment
There was a problem hiding this comment.
If there's a need for an additional issue - create it - we can always close it after,
the in-editor item spawn indicator icons aren't transparent (are black squares with icon) on my end, but I guess it's some setting I don't have on
other than that LGTM
| @@ -50,7 +50,7 @@ public class PlayerCamera : MonoBehaviour, DefaultInputActions.IPlayerCameraActi | |||
| private float yInput; | |||
| private float yRotation; | |||
| private float zoomFov; | |||
| public bool IsFirstPerson { get; private set; } = true; | |||
| public bool IsFirstPerson { get; private set; } = false; | |||
There was a problem hiding this comment.
3rd-person camera should remain the default. If it is too problematic, we should create an issue to improve the 3rd-person camera QoL-wise, not replace it.
There was a problem hiding this comment.
Very well, since 1st-person camera seems to make testing much easier, we can switch to it temporarily. However, next time, this should be done in a dedicated PR and discussed beforehand
There was a problem hiding this comment.
Move or duplicate to Scenes/Demo
There was a problem hiding this comment.
I think this scene is for testing. A "Demo" scene should be separate think.
I will update current Scenes/Demo/* to include all changes made here
|
I will wait with this PR until #141 is merged |
Acu1000
left a comment
Acu1000
left a comment
There was a problem hiding this comment.
Everything is good. Just one more thing - remove Scenes/Demo/FullTest. It was originally meant to serve the same purpose and is now obsolete.
4 participants
Closes #105
Some prefabs cannot be included in GameManagerScene due to dependencies to Playerpreview: