feat(#125): connect programming UI to robots by strunk23 · Pull Request #138 · grupacosmo/cosmobot

strunk23 · 2026-03-26T11:11:15Z

closes #125

PatrykPaluch

Just locking cr. I will look later on this

PatrykPaluch · 2026-03-26T16:21:56Z

        [TextArea(10, 20)]
-        [SerializeField] private string code;
+
+        public string code;


I'm not sure about making it public like that. I think we needs to check if the robot is running to avoid mismatched "code in variable" and actually running code in engine

PatrykPaluch · 2026-03-26T16:55:42Z

+        public void StopTask()
+        {
+            StopAllCoroutines();
+            commandQueue.Clear();
+
+            cancellationTokenSource?.Cancel();
+            cancellationTokenSource?.Dispose();
+            cancellationTokenSource = null;
        }


I need to double check this

PatrykPaluch · 2026-03-26T16:58:44Z

            catch (OperationCanceledException)
            {
-                Debug.Log("[Programmable JsThread] Operation was cancelled");
+                Debug.LogError("Operation was cancelled");


I'm not sure if this is an Error or even a warning - in my opinion just info. Also, previous message was more descriptive

PatrykPaluch · 2026-03-26T18:18:36Z

            taskCompletedEvent = new ManualResetEvent(false);
+
+            debugI = staticDebugI++;
+            engineLogicInterfaces = GetComponents<IEngineLogic>();


I think about moving this to startTask

Acu1000

This bug occured when I first tried it:

Steps to reproduce:

Go to saves folder (you can do Debug.Log(Application.persistentDataPath))
Delete JsFiles folder
Start the game in the RobotAPI scene, interact with the robot to open the UI
Create a new script (error happens regardless of the script's content)
Click "Run"

Acu1000 · 2026-03-27T19:17:00Z

I tried running a simple "while true: move forward, rotate 45deg" script and the robot does not seem to move in an octagonal path as expected, but I don't believe this is in the scope of this PR

PatrykPaluch

And i created #141 so wait for it with the PlayerCamera/PlayerController changes. I will try to close #141 asap (i will assign task to me when i start working on it), but if you are bored and i'm still not assigned to this issue, then feel free to take over it 😛

PatrykPaluch · 2026-03-27T19:23:09Z

+        public void RunActiveFile()
+        {
+            if (IsUiInteractionInvalid("Found no files to execute")) { return; }
+            fileManager.RunActiveFile();
+        }
+
+        public void StopActiveFile()
+        {
+            if (IsUiInteractionInvalid("Found no files to stop")) { return; }
+            fileManager.StopActiveFile();
+        }


Run/Stop in Canvas should be replace by one button that will change to "Run"/"Stop" depending on running state. Additionally i would add running indicator - just label "running" maybe with timer but timer is not necessary.

keep in mind that program can be stopped by other sources or can finish execution by it self. So you probably need to add some event listeners to Programmable for task start and end.

PatrykPaluch · 2026-03-27T21:01:50Z

@@ -11,7 +11,8 @@ namespace Cosmobot
 {
    public class ProgrammingUi : MonoBehaviour


Console is not robot specific. When you open robot programming ui, player should see logs for that robot

PatrykPaluch · 2026-03-27T21:09:26Z

+    public class RobotUiInteractionHandler : MonoBehaviour, IInteractable
+    {
+        [SerializeField]
+        private ProgrammingUiManager programmingUiManager;


i think ProgramminUiManager should be SingletonSystem and accessible by Instance static variable (just implement SingletonSystem and replace Awake/Start with override void SystemAwake

PatrykPaluch · 2026-03-27T22:33:56Z

+        [SerializeField]
+        private PlayerCamera playerCamera;


im starting to think about implementing GameManager with all that player stuff before continuing with this PR

Good idea. We'll consider adding it once the current PRs are merged. I believe we can merge this one without it though.

As I stated in comment to this PR, we should wait until GameManager is merged. This is already an issue, and there are already two PR that make this issue more time consuming. For now GameManager is only new class and one change in Construction script. Implementing GameManager first will be easier and faster, than implementing it afterwards

PatrykPaluch · 2026-03-27T22:37:05Z


        private void OnEnable()
        {
+            RobotLogger.AddAllLogEventHandler(logManager.CreateLog);


ProgrammingUiLogManager is an MonoBehaviour script, so it should register event handler by its own

PatrykPaluch · 2026-03-27T22:51:13Z

-        }
-
-        public void CreateLog(long time, LogLevel level, string message)
+        public void CreateLog(ProgrammableData data, LogEntry logEntry)


This function should check if it is necessary to instantiate new ui elements. These are still gameobject and can impact performance. Im not sure how exacly Canvas remeshing/rendering works, but im would prefer not to create new game objects if UI is not visible to user.

You can also just unsubscribe event when UI is closed and subscribe again on OpenUI.

To retrieve all logs that ware logged before opening UI you can use RobotLogger.TryGetRobotLogs function. This will also help whit changing view between robots.

Logs are dynamic so i think its good place for pooling. Create pool of those ProgrammingUiLogEntry GameObjects with some max size (eg. 200). If new logs appear after using up the pool, just reuse the oldest object. Yes, this will limit number of logs visible to player, but its better than spamming and deleting new GameObject indefinitely. Sooner or later we will use pooling so i think its good time and place to implement it. I think i have some universal pooling script i created for other project, DM me and i will send you script.

PatrykPaluch · 2026-03-27T23:10:46Z

+        public void CreateNewFile()
+        {
+            fileManager.CreateNewFile("file" + fileManager.GetFileCount() + ".js"); // TEMP
+        }


if possible this should ask user for file name. Maybe rename button (just "R" for now to keep it small, we will later add icons).

If this is too much coding for this task then ignore this comment, we will probably rewrite entire UI later to UI Elements, so try not to work on Canvas specific stuff too much

Manual setting of file names is a job for a separate task, no need to worry about it in this PR

PatrykPaluch · 2026-03-27T23:12:01Z

+        public void CloseUI()
+        {
+            ChangeUiState(false);
+        }


if possible add ESC to close UI

PatrykPaluch · 2026-03-27T23:13:57Z

+
+        private Programmable robot;
+
+        public string Prompt { get; private set; } = "Press 'E' to interact";


"Press 'E' to program the robot"
or
"Press 'E' to open programming window"
or something like that

PatrykPaluch · 2026-04-01T19:13:23Z

#143 merged

You can now pull main and replace all "manual" player references to GameManager (for now you need to add one GameManager to the scene, this will be fixed with #137, but that will be my job, if you marge this PR faster than i #137 😄)

PatrykPaluch · 2026-04-09T09:11:19Z

#137 was merged today, so now you will have conflicts with scenes (as you can see in merge window below). So:

Add working example to 0_MainTestScene (keep it simple)
You can keep your testing scene (RobotAPI if i remember correctly) with you feature isolated
If Player prefab needs some component added, a reference to external GameObject, put that GameObject in PlayerBase prefab

also remember about GameManager from my previous commend

strunk23 added 11 commits January 15, 2026 16:31

confirm file remove

aefa49b

save/load files on disk, update UI with file content

0761603

open programming ui on robot click

fb9c185

fix repeating entries

1ecbc5d

open file execution

0570e1a

active file execution WIP

7682a1f

Stop task execution, robots send logs to UI, code cleanup

2b913cb

robots have assigned active and open files

753efa4

improved file switching, fixed minor bugs

b1aa110

comment

dede19c

code formatting

89b239d

strunk23 requested review from Acu1000, PatrykPaluch and StaszkeKun March 26, 2026 11:11

strunk23 marked this pull request as draft March 26, 2026 11:16

strunk23 and others added 5 commits March 26, 2026 12:48

Merge branch 'main' into feat/125/connect-programming-ui-to-robots

a6f86c3

code formatting v2

74248fe

switched to robot logging

cc5f219

robot interaction via Interactable

172a761

code formatting v3

d79c246

strunk23 marked this pull request as ready for review March 26, 2026 14:25

strunk23 added 3 commits March 26, 2026 16:07

folder location fix

cb6e1e7

path fixes

3331c48

remove redundant line

747d789

PatrykPaluch requested changes Mar 26, 2026

View reviewed changes

Acu1000 requested changes Mar 27, 2026

View reviewed changes

PatrykPaluch requested changes Mar 27, 2026

View reviewed changes

		@@ -11,7 +11,8 @@ namespace Cosmobot
		{
		public class ProgrammingUi : MonoBehaviour


		private Programmable robot;

		public string Prompt { get; private set; } = "Press 'E' to interact";

Conversation

strunk23 commented Mar 26, 2026

Uh oh!

PatrykPaluch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Acu1000 left a comment

Choose a reason for hiding this comment

Uh oh!

Acu1000 commented Mar 27, 2026

Uh oh!

PatrykPaluch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Acu1000 Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Acu1000 Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PatrykPaluch commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PatrykPaluch commented Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Acu1000 Mar 29, 2026 •

edited

Loading

Acu1000 Mar 29, 2026 •

edited

Loading

PatrykPaluch commented Apr 1, 2026 •

edited

Loading