Skip to content

refactor(compiler): move script gen outside of compiler and into container #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 4 commits into from
Mar 5, 2026
Merged

refactor(compiler): move script gen outside of compiler and into container #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c72a13
refactor(compiler): move script gen outside of compiler and into cont…
ecrupper Mar 5, 2026
f8f896c
linter
ecrupper Mar 5, 2026
7b5c987
Merge branch 'main' into refactor/fix/script-call
ecrupper Mar 5, 2026
e2f2d26
add back errant removal of number set
ecrupper Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions compiler/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,6 @@ type Engine interface {
// InitStep step process into a yaml configuration.
InitStep(*yaml.Build) (*yaml.Build, error)

// Script Compiler Interface Functions

// ScriptStages defines a function that injects the script
// for each step in every stage in a yaml configuration.
ScriptStages(yaml.StageSlice) (yaml.StageSlice, error)
// ScriptSteps defines a function that injects the script
// for each step in a yaml configuration.
ScriptSteps(yaml.StepSlice) (yaml.StepSlice, error)

// Substitute Compiler Interface Functions

// SubstituteStages defines a function that replaces every
Expand Down
12 changes: 0 additions & 12 deletions compiler/native/compile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,12 +417,6 @@ func (c *Client) compileSteps(ctx context.Context, p *yaml.Build, _pipeline *api
return nil, _pipeline, err
}

// inject the scripts into the steps
p.Steps, err = c.ScriptSteps(p.Steps)
if err != nil {
return nil, _pipeline, err
}

// create executable representation
build, err := c.TransformSteps(r, p)
if err != nil {
Expand Down Expand Up @@ -525,12 +519,6 @@ func (c *Client) compileStages(ctx context.Context, p *yaml.Build, _pipeline *ap
return nil, _pipeline, err
}

// inject the scripts into the stages
p.Stages, err = c.ScriptStages(p.Stages)
if err != nil {
return nil, _pipeline, err
}

// create executable representation
build, err := c.TransformStages(r, p)
if err != nil {
Expand Down
Loading
Loading