refactor(compiler): move script gen outside of compiler and into container#1403
Merged
refactor(compiler): move script gen outside of compiler and into container#1403
Conversation
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (58.25%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
==========================================
- Coverage 58.26% 58.25% -0.01%
==========================================
Files 661 660 -1
Lines 25301 25286 -15
==========================================
- Hits 14742 14731 -11
+ Misses 9870 9868 -2
+ Partials 689 687 -2
🚀 New features to boost your workflow:
|
wass3rw3rk
reviewed
Mar 5, 2026
wass3rw3rk
approved these changes
Mar 5, 2026
timhuynh94
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By moving this routine outside of the compiler and into the
pipeline.Containermethod set, we can call it in the worker code. This fixes the issue introduced in #1353 where if a user has${VELA_BUILD_NUMBER}or${VELA_BUILD_LINK}in theircommandsblock, it would need to be declared in a way that allows shell substitution.While this is probably not all that common (and fixable), I would argue this script routine is better suited as a container method anyway. It does not rely on any compiler information.