feat: Validate add.stats. numRecords must exist on writes when icebergCompatV3 enabled#2512
feat: Validate add.stats. numRecords must exist on writes when icebergCompatV3 enabled#2512dengsh12 wants to merge 11 commits intodelta-io:mainfrom
add.stats. numRecords must exist on writes when icebergCompatV3 enabled#2512Conversation
add.stats. numRecords must exist on writes when icebergCompatV3 enabled
| // IcebergCompatV3 requires every AddFile to carry `stats.numRecords`. | ||
| if self | ||
| .effective_table_config | ||
| .is_feature_enabled(&TableFeature::IcebergCompatV3) | ||
| { | ||
| stats_verifier::verify_num_records_present(add_files)?; | ||
| } |
There was a problem hiding this comment.
Currently we never enter this if branch since we can't write to icebergCompatV3 tables. Will covered by later integration tests
eb4f572 to
8480dfe
Compare
|
PR title does not match the required pattern. Please ensure you follow the conventional commits spec. Your title should start with Title: Your title should start with Title: Your title should start with Title: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
==========================================
+ Coverage 88.50% 88.56% +0.05%
==========================================
Files 179 179
Lines 59031 59551 +520
Branches 59031 59551 +520
==========================================
+ Hits 52245 52739 +494
- Misses 4785 4803 +18
- Partials 2001 2009 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
Added a new
NumRecordsValidatorto validateadd.stats.numRecordsmust exist on writes whenicebergCompatV3enabled. Renamed ExistingStatsVerifiertoStatsColumnVerifierto distinguish.How was this change tested?
Unit tests for:
EngineDatabatches.EngineDatabatches with severalnumRecordsasNone(validates early-return).EngineDatabatches with severalnumRecordsasNone(validates early-return).EngineDatabatch withnumRecordsin all add actions.