feat: Block alter table when icebergCompatV3 enabled#2505
Open
dengsh12 wants to merge 6 commits intodelta-io:mainfrom
Open
feat: Block alter table when icebergCompatV3 enabled#2505dengsh12 wants to merge 6 commits intodelta-io:mainfrom
icebergCompatV3 enabled#2505dengsh12 wants to merge 6 commits intodelta-io:mainfrom
Conversation
This was referenced Apr 30, 2026
dengsh12
changed the title
icebergCompatV3 enabled
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2505 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 179 179
Lines 59031 59036 +5
Branches 59031 59036 +5
=======================================
+ Hits 52245 52250 +5
Misses 4785 4785
Partials 2001 2001 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
the
breaking-change
dengsh12
commented
Apr 30, 2026
| committer: Box<dyn Committer>, | ||
| ) -> DeltaResult<AlterTableTransaction> { | ||
| let table_config = self.snapshot.table_configuration(); | ||
| // We don't support ALTER TABLE on tables with icebergCompatV3 enabled yet. See |
Collaborator
Author
There was a problem hiding this comment.
Note: We could put the validation on constructor of the AlterTableTransactionBuilder(i.e. add a try_new) and fail early. But that breaks all callers by a DeltaResult(currently constructor of AlterTableTransactionBuilder never fails). As this is a temporal limitation, feel like not need to break callers here
dengsh12
force-pushed
the
stack/block-alter-table
branch
from
70b7fb4 to
ffd8ecb
Compare
dengsh12
force-pushed
the
stack/block-alter-table
branch
from
ffd8ecb to
cae1ea9
Compare
github-actions
Bot
removed
the
breaking-change
dengsh12
changed the title
icebergCompatV3 enabledicebergCompatV3 enabled
dengsh12
changed the title
icebergCompatV3 enabledicebergCompatV3 enabled
dengsh12
force-pushed
the
stack/block-alter-table
branch
from
d85955c to
3f1154c
Compare
Jameson-Crate
pushed a commit
to Jameson-Crate/delta-kernel-rs
that referenced
this pull request
May 1, 2026
…#2475) ## 🥞 Stacked PR Use this [link](https://github.com/delta-io/delta-kernel-rs/pull/2475/files) to review incremental changes. - [**stack/add-v3-feature**](delta-io#2475) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2475/files)] - stack/write-nested-id - [stack/write-part-when-ice3](delta-io#2504) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2504/files/e1a4b559271b72323a9b560aa456db49276b63e1..9f777f08559a7f0b7e014756182fbcb1ae788996)] - [stack/block-alter-table](delta-io#2505) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2505/files/9f777f08559a7f0b7e014756182fbcb1ae788996..ffd8ecb8ce71681530b92f3683977bd58b9d57b0)] --------- ## Stacked PR Use this [link](https://github.com/delta-io/delta-kernel-rs/pull/2475/files) to review incremental changes. - [**stack/add-v3-feature**](delta-io#2475) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2475/files)] - stack/write-nested-id - [stack/write-part-when-ice3](delta-io#2504) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2504/files/e1a4b559271b72323a9b560aa456db49276b63e1..5442d0979cbe36fc2eb1e85bf0a79bc01c30e121)] --------- ## What changes are proposed in this pull request? Add `icebergCompatV3` and it's `FeatureInfo` ## How was this change tested? Tested happy/unhappy paths for `icebergCompatV3`: 1. Error when row tracking not enabled 2. Error when column mapping not enabled 3. Error when `icebergCompatV1/V2` enabled 4. `icebergCompatV3` enablement follows the corresponding table property 5. Write operation is blocked 6. Success when all requirements are met
dengsh12
force-pushed
the
stack/block-alter-table
branch
from
3f1154c to
ff634da
Compare
scottsand-db
reviewed
May 1, 2026
| // [`crate::table_features::ICEBERG_COMPAT_V3_INFO`] for the tracking issue. | ||
| if table_config.is_feature_enabled(&TableFeature::IcebergCompatV3) { | ||
| return Err(Error::unsupported( | ||
| "ALTER TABLE is not supported on tables with icebergCompatV3 enabled", |
Collaborator
There was a problem hiding this comment.
This error makes it seem like ALTER TABLE is fundamentally not supported on IcebergCompatV3 tables.
The reality is: ALTER TABLE is not yet supported on IcebergCompatV3 tables.
Please add yet there.
Collaborator
Author
There was a problem hiding this comment.
Good point! Clarified: added yet
scottsand-db
approved these changes
May 1, 2026
Collaborator
scottsand-db
left a comment
scottsand-db
left a comment
There was a problem hiding this comment.
LGTM but please implement my feedback to clarify and improve the error message
dengsh12
force-pushed
the
stack/block-alter-table
branch
from
ff634da to
bfb086b
Compare
dengsh12
force-pushed
the
stack/block-alter-table
branch
from
562605f to
cd4bf3f
Compare
CynicDog
pushed a commit
to CynicDog/delta-kernel-rs
that referenced
this pull request
May 2, 2026
…lta-io#2504) ## Stacked PR Use this [link](https://github.com/delta-io/delta-kernel-rs/pull/2504/files) to review incremental changes. - [stack/add-v3-feature](delta-io#2475) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2475/files)] [MERGED] - [**stack/write-part-when-ice3**](delta-io#2504) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2504/files)] - [stack/block-alter-table](delta-io#2505) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2505/files/15d151f8b271a72cb421ccfa81cda7d5887d1b37..562605f3911acd99854efae7940deb9344e7ee55)] - [stack/write-nested-id](delta-io#2508) [[Files changed](https://github.com/delta-io/delta-kernel-rs/pull/2508/files/562605f3911acd99854efae7940deb9344e7ee55..766ace41c2176c546f533be4ff0d7a9aa24ae001)] --------- ## What changes are proposed in this pull request? Materialize partition values when icebergCompatV3 enabled. ## How was this change tested? 1. When `icebergCompatV3` enabled, partition columns are contained into `physical_write_schema` 2. When `icebergCompatV3` supported but not enabled, partition columns are not contained into `physical_write_schema` Note: other related cases(e.g. `MaterializePartitionColumns`) are already covered by existing tests so we are not adding tests here
Jameson-Crate
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
Block alter table when icebergCompatV3 enabled. Alter table transactions are expected to build from
AlterTableTransactionBuilder::build, thus we block that function on icebergCompatV3 tables.How was this change tested?
Integration test: create an
icebergCompatV3table and validate the error.Note: Successful paths have been covered by existing tests so we are not adding test for successful path here