Skip to content

[collection] Clarify map modification during iteration#63007

Open
khanak0509 wants to merge 3 commits intodart-lang:mainfrom
khanak0509:hashmap-doc-clarify-value-mutation-62175
Open

[collection] Clarify map modification during iteration#63007
khanak0509 wants to merge 3 commits intodart-lang:mainfrom
khanak0509:hashmap-doc-clarify-value-mutation-62175

Conversation

@khanak0509
Copy link
Copy Markdown
Contributor

This PR updates the Map and HashMap documentation to explicitly state that updating the value of an existing key is allowed during iteration.

PR #62175

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

@copybara-service
Copy link
Copy Markdown

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/491620

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).

@khanak0509
Copy link
Copy Markdown
Contributor Author

Hii , I also checked map.dart, should I also update the class-level notice there too.

@copybara-service
Copy link
Copy Markdown

https://dart-review.googlesource.com/c/sdk/+/491620 has been updated with the latest commits from this pull request.

1 similar comment
@copybara-service
Copy link
Copy Markdown

https://dart-review.googlesource.com/c/sdk/+/491620 has been updated with the latest commits from this pull request.

@copybara-service
Copy link
Copy Markdown

CL has new comments, please view and respond to them in Gerrit.

If a reviewer requested changes, push new commits to this PR and it will be automatically copied to Gerrit. After that you can mark reviewer comments as resolved in Gerrit and request another round of reviews.

Note: when you add comments in Gerrit they only become visible after you send them by clicking Reply and Send.

@copybara-service
Copy link
Copy Markdown

Gerrit CL has been approved, please wait for a reviewer to merge it.

There are also new comments on the CL, please review them and respond if necessary because reviewer might have requested clarifications or possibly some final changes and will not merge the CL until their questions have been answered.

@copybara-service
Copy link
Copy Markdown

https://dart-review.googlesource.com/c/sdk/+/491620 has been updated with the latest commits from this pull request.

@copybara-service
Copy link
Copy Markdown

CL has new comments, please view and respond to them in Gerrit.

If a reviewer requested changes, push new commits to this PR and it will be automatically copied to Gerrit. After that you can mark reviewer comments as resolved in Gerrit and request another round of reviews.

Note: when you add comments in Gerrit they only become visible after you send them by clicking Reply and Send.

@copybara-service
Copy link
Copy Markdown

https://dart-review.googlesource.com/c/sdk/+/491620 has been updated with the latest commits from this pull request.

@copybara-service
Copy link
Copy Markdown

CL has new comments, please view and respond to them in Gerrit.

If a reviewer requested changes, push new commits to this PR and it will be automatically copied to Gerrit. After that you can mark reviewer comments as resolved in Gerrit and request another round of reviews.

Note: when you add comments in Gerrit they only become visible after you send them by clicking Reply and Send.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant