Conversation
8a32cdb to
7b372b7
Compare
…_exports to carry defaults
… as exceptions are not available for C++ yet
…r to how Views worked with errors + added a version of IterBuf for C++ to start to reduce allocations
7b372b7 to
fa45b54
Compare
jdetter
left a comment
There was a problem hiding this comment.
I've tested this at least with the basic quickstart doc and everything seems to be working. I also looked back and did another pass on the comments that I put down - let me know if you need me to take another look at anything.
I have not done a nit-pick review on the code here since there is quite a lot but I have skimmed it and haven't found anything too concerning. I think it would be better to do a UX review when we go through the follow-up docs PRs anyway. Please request my review when those are ready as well.
Thanks Jason, this is great 👍
gefjon
left a comment
There was a problem hiding this comment.
I've only looked at the procedure-related stuff in here, but it looks great - much better than I expected, to be honest. Thanks for all your hard work on this!
joshua-spacetime
left a comment
There was a problem hiding this comment.
The view code looks correct. sender is a method in the 2.0 rust module api. But as I understand it, this is not meant to be 2.0 compliant. Also this does not include the query builder which will be added separately.
jdetter
left a comment
There was a problem hiding this comment.
I reviewed the changes to tools/upgrade-version and the new versioning change, everything looks good here - just a reminder to make sure everything is tested before merging 🙂
Thanks Jason!
cloutiertyler
left a comment
There was a problem hiding this comment.
Approving my code owned files. Left one comment.
Description of Changes
This adds C++ server bindings (/crate/bindings-cpp) to allow writing C++ 20 modules.
API and ABI breaking changes
None
Expected complexity level and risk
2 - Doesn't heavily impact any other areas but is complex macro C++ structure to support a similar developer experience, did have a small impact on init command
Testing