Skip to content

fix: publish docker and package artifacts in release flow#199

Merged
chopratejas merged 4 commits intochopratejas:mainfrom
JerrettDavis:fix/release-publish-artifacts
Apr 20, 2026
Merged

fix: publish docker and package artifacts in release flow#199
chopratejas merged 4 commits intochopratejas:mainfrom
JerrettDavis:fix/release-publish-artifacts

Conversation

@JerrettDavis
Copy link
Copy Markdown
Contributor

Summary

  • call the Docker workflow from release.yml so Docker publishes in the same release run instead of relying on a release event that GITHUB_TOKEN does not trigger
  • build npm tarballs alongside the Python distributions and upload them to the GitHub release as assets
  • document that the unified release flow now publishes version-matched Docker images and GitHub-hosted package assets

Validation

  • uv run --extra dev python -m pytest scripts/tests/test_version_sync.py tests/test_release_version.py -q

Why

The current release workflow can succeed without publishing Docker at all, and the GitHub release page ends up with no Python or npm artifacts. This change makes the GitHub release the place where Docker publication and release assets land together, alongside the remote package publishes.

Call the Docker workflow from the release pipeline so Docker publishes in

the same run, build npm tarballs alongside Python distributions, and

attach those artifacts to the GitHub release page.

Co-authored-by: Copilot <[email protected]>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 18, 2026

Codecov Report

❌ Patch coverage is 90.54054% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
headroom/compress.py 90.54% 5 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

JerrettDavis and others added 3 commits April 18, 2026 15:38
Add a workflow-validation CI job that installs actionlint and act,
checks the release and Docker workflows against checked-in event
fixtures, and shares the same validation script developers can run
locally.

Co-authored-by: Copilot <[email protected]>
Fix workflow validation failures by wiring detect-version outputs into all
release publish jobs, renaming the GitHub Packages skip variable to a
valid Actions variable name, and adjusting the macOS PATH export for
actionlint.

Also make min_tokens_to_compress use token counting instead of whitespace
splits so compact JSON tool outputs still compress after merging the
latest main branch changes, and add a regression test for that path.

Co-authored-by: Copilot <[email protected]>
Bring the branch onto upstream/main so GitHub validates the same merged
compression code locally, and install act into PATH for the
workflow-validation job.

This keeps the compact-JSON compression regression fixed while making
the shared validation script pass in CI.

Co-authored-by: Copilot <[email protected]>
@JerrettDavis JerrettDavis force-pushed the fix/release-publish-artifacts branch from bc0a366 to 8a6579b Compare April 18, 2026 21:17
@chopratejas chopratejas merged commit eff1616 into chopratejas:main Apr 20, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants