Skip to content

docs: fix typos and improve error message in DateTimeFormat #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nakshatra480 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs: fix typos and improve error message in DateTimeFormat #4933

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4a4653
docs: fix typos and error message in DateTimeFormat
Mar 7, 2026
5bf45be
Merge branch 'main' into feat/intl-datetimeformat-supportedlocalesof
Nakshatra480 Mar 7, 2026
a58ea58
Merge branch 'main' into feat/intl-datetimeformat-supportedlocalesof
Nakshatra480 Mar 8, 2026
8ebaa93
Merge branch 'main' into feat/intl-datetimeformat-supportedlocalesof
Nakshatra480 Mar 10, 2026
ffc7925
Merge branch 'main' into feat/intl-datetimeformat-supportedlocalesof
Nakshatra480 Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/engine/src/builtins/intl/date_time_format/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ impl DateTimeFormat {
// 3. Perform ? RequireInternalSlot(dtf, [[InitializedDateTimeFormat]]).
let dtf_object = object.downcast::<Self>().map_err(|_| {
JsNativeError::typ()
.with_message("the `this` object must be an initializedDateTimeFormat object")
.with_message("the `this` object must be an initialized DateTimeFormat object")
})?;
let dtf_clone = dtf_object.clone();
let mut dtf = dtf_object.borrow_mut();
Expand Down Expand Up @@ -491,7 +491,7 @@ impl ToLocalTime {
pub(crate) fn to_formattable_datetime(&self) -> DateTime<Iso> {
DateTime {
date: Date::try_new_iso(self.year, self.month, self.day)
.expect("TimeClip insures valid range."),
.expect("TimeClip ensures valid range."),
time: Time::try_new(self.hour, self.minute, self.second, self.subsecond)
.expect("valid values"),
}
Expand Down
Loading