docs: fix typos and improve error message in DateTimeFormat#4933
Open
Nakshatra480 wants to merge 2 commits intoboa-dev:mainfrom
Open
docs: fix typos and improve error message in DateTimeFormat#4933Nakshatra480 wants to merge 2 commits intoboa-dev:mainfrom
Nakshatra480 wants to merge 2 commits intoboa-dev:mainfrom
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4933 +/- ##
===========================================
+ Coverage 47.24% 57.79% +10.55%
===========================================
Files 476 556 +80
Lines 46892 60927 +14035
===========================================
+ Hits 22154 35213 +13059
- Misses 24738 25714 +976 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
881c6d5 to
aa002e7
Compare
aa002e7 to
e4a4653
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses small documentation and usability issues in the
Intl.DateTimeFormatimplementation. By fixing a common typo and improving error message readability, we enhance the overall code quality and developer experience.Changes Made
insurestoensuresin theexpectmessage within theToLocalTimeimplementation in mod.rs.TypeErrormessage in theget_formataccessor in mod.rs. ChangedinitializedDateTimeFormattoinitialized DateTimeFormatto make the error more readable for users.Verification
Intl.DateTimeFormattests still pass:dtf_basic— Passedsupported_locales_of— Passed