Skip to content

Fix retirejs crash on URL_UNVERIFIED parent events from gowitness #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liquidsec merged 1 commit into from
Mar 24, 2026
+3 −1
Merged

Fix retirejs crash on URL_UNVERIFIED parent events from gowitness #2987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bbot/modules/retirejs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ async def handle_event(self, event):
"severity": severity,
"confidence": "HIGH",
"component": component,
"url": event.parent.data["url"],
"url": event.parent.parsed_url.geturl(),
}
await self.emit_event(
data,
Expand Down
2 changes: 2 additions & 0 deletions bbot/test/test_step_2/module_tests/test_module_retirejs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ def check(self, module_test, events):
for finding in retirejs_findings:
assert "description" in finding.data, "Finding should have description"
assert "url" in finding.data, "Finding should have url"
# url field should point to the page that loaded the JS, not the JS file itself
assert finding.data["url"] == "http://127.0.0.1:8888/", "url should be the parent page URL"
assert finding.parent.type == "URL_UNVERIFIED", "Parent should be URL_UNVERIFIED"


Expand Down
Loading