Fix retirejs crash on URL_UNVERIFIED parent events from gowitness#2987
Merged
Fix retirejs crash on URL_UNVERIFIED parent events from gowitness#2987
Conversation
Use event.parent.parsed_url.geturl() to get the source page URL instead of event.parent.data["url"] which crashes on URL_UNVERIFIED parents (string data, not dict).
Contributor
📊 Performance Benchmark Report
📈 Detailed Results (All Benchmarks)
🎯 Performance Summary✅ No significant performance changes detected (all changes <10%) 🐍 Python Version 3.11.15 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.0 #2987 +/- ##
=====================================
- Coverage 91% 91% -0%
=====================================
Files 436 436
Lines 36918 36919 +1
=====================================
- Hits 33567 33549 -18
- Misses 3351 3370 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheTechromancer
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string indices must be integers, not 'str'crash inretirejs.handle_event()at line 191event.parent.data["url"]assumed the parent event's data was a dict, but URL_UNVERIFIED parents (e.g. from gowitness) have string dataevent.parent.parsed_url.geturl()which works for all URL-bearing parent types (URL, URL_UNVERIFIED, HTTP_RESPONSE)urlfield points to the parent page, not the JS file itself