Skip to content

Switch CODEOWNERS from sip to cli team #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremy merged 2 commits into from
Mar 18, 2026
Merged

Switch CODEOWNERS from sip to cli team #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01ab15d
Switch CODEOWNERS from sip to cli team
jeremy Mar 18, 2026
e1cc777
Fix staticcheck SA5011 nil pointer warnings in tests
jeremy Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
* @basecamp/sip
.github/workflows/ @basecamp/sip
* @basecamp/cli
.github/workflows/ @basecamp/cli
Comment on lines +1 to +2
1 change: 1 addition & 0 deletions internal/tui/debug_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ func TestEnterOnBoxPostingTriggersFetch(t *testing.T) {
posting := m.box.selectedPosting()
if posting == nil {
t.Fatal("selectedPosting() is nil")
return
}
t.Logf("selected posting: %+v", posting)
t.Logf("posting.Topic: %+v", posting.Topic)
Expand Down
2 changes: 2 additions & 0 deletions internal/tui/tui_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ func TestBoxesLoadedMsg(t *testing.T) {
selected := result.boxes.selectedBox()
if selected == nil {
t.Fatal("selectedBox() returned nil after setting items")
return
}
if selected.Name != "Imbox" {
t.Errorf("first selected box = %q, want %q", selected.Name, "Imbox")
Expand Down Expand Up @@ -783,6 +784,7 @@ func TestCalendarsLoadedMsg(t *testing.T) {
selected := result.calendars.selectedCalendar()
if selected == nil {
t.Fatal("selectedCalendar() returned nil after setting items")
return
}
if selected.Name != "My Calendar" {
t.Errorf("first selected calendar = %q, want %q", selected.Name, "My Calendar")
Expand Down
Loading