Conversation
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
There was a problem hiding this comment.
Pull request overview
This PR updates repository ownership rules to route CODEOWNERS review requests from the @basecamp/sip team to the @basecamp/cli team, reducing review noise for sip.
Changes:
- Update the default CODEOWNERS entry (
*) to@basecamp/cli. - Update
.github/workflows/ownership to@basecamp/cli.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Routes automatic review requests away from @basecamp/sip and toward @basecamp/cli by updating repository CODEOWNERS, reducing SIP review noise.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Update
.github/CODEOWNERSto assign ownership to@basecamp/cli(including workflow files). - Add explicit
returnstatements aftert.Fatal(...)in a few TUI tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/tui/tui_test.go | Adds explicit returns after t.Fatal in nil-guarded test branches. |
| internal/tui/debug_test.go | Adds explicit return after t.Fatal in a nil-guarded test branch. |
| .github/CODEOWNERS | Switches code ownership from @basecamp/sip to @basecamp/cli. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * @basecamp/cli | ||
| .github/workflows/ @basecamp/cli |
Reduces review noise for the sip team by routing ownership to the cli team.
Summary by cubic
Switch CODEOWNERS from
@basecamp/sipto@basecamp/cli(all files and.github/workflows/) and fix SA5011 nil-pointer warnings in tests.Written for commit e1cc777. Summary will update on new commits.