Skip to content

Switch CODEOWNERS from sip to cli team#43

Merged
jeremy merged 2 commits intomainfrom
switch-codeowners-to-cli-team
Mar 18, 2026
Merged

Switch CODEOWNERS from sip to cli team#43
jeremy merged 2 commits intomainfrom
switch-codeowners-to-cli-team

Conversation

@jeremy
Copy link
Copy Markdown
Member

@jeremy jeremy commented Mar 18, 2026

Reduces review noise for the sip team by routing ownership to the cli team.


Summary by cubic

Switch CODEOWNERS from @basecamp/sip to @basecamp/cli (all files and .github/workflows/) and fix SA5011 nil-pointer warnings in tests.

Written for commit e1cc777. Summary will update on new commits.

@jeremy jeremy requested a review from a team as a code owner March 18, 2026 19:21
Copilot AI review requested due to automatic review settings March 18, 2026 19:21
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 18, 2026

Sensitive Change Detection (shadow mode)

This PR modifies control-plane files:

  • .github/CODEOWNERS

Shadow mode — this check is informational only. When activated, changes to these paths will require approval from a maintainer.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 18, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository ownership rules to route CODEOWNERS review requests from the @basecamp/sip team to the @basecamp/cli team, reducing review noise for sip.

Changes:

  • Update the default CODEOWNERS entry (*) to @basecamp/cli.
  • Update .github/workflows/ ownership to @basecamp/cli.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jeremy jeremy requested a review from Copilot March 18, 2026 19:40
@github-actions github-actions bot added bug Something isn't working and removed documentation Improvements or additions to documentation labels Mar 18, 2026
@jeremy jeremy merged commit 3f62c1f into main Mar 18, 2026
30 checks passed
@jeremy jeremy deleted the switch-codeowners-to-cli-team branch March 18, 2026 19:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Routes automatic review requests away from @basecamp/sip and toward @basecamp/cli by updating repository CODEOWNERS, reducing SIP review noise.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

  • Update .github/CODEOWNERS to assign ownership to @basecamp/cli (including workflow files).
  • Add explicit return statements after t.Fatal(...) in a few TUI tests.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
internal/tui/tui_test.go Adds explicit returns after t.Fatal in nil-guarded test branches.
internal/tui/debug_test.go Adds explicit return after t.Fatal in a nil-guarded test branch.
.github/CODEOWNERS Switches code ownership from @basecamp/sip to @basecamp/cli.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +2
* @basecamp/cli
.github/workflows/ @basecamp/cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants