Updating templates with developments from mecanum_controller by EXPX3 · Pull Request #106 · b-robotized/ros_team_workspace

EXPX3 · 2023-02-23T15:02:05Z

created a ros2_controller package from this template and all tests pass, tests specific to ref_timeout are not included as they are being addressed in #73

mergify · 2023-02-23T15:02:38Z

This pull request is in conflict. Could you fix it @Robotgir?

templates/ros2_control/controller/test_dummy_chainable_controller.cpp

templates/ros2_control/controller/test_dummy_controller_preceeding.cpp

templates/ros2_control/controller/dummy_chainable_controller.cpp

templates/ros2_control/controller/test_dummy_chainable_controller.cpp

corrections

templates/ros2_control/controller/dummy_chainable_controller.cpp

templates/ros2_control/controller/dummy_controller.yaml

Co-authored-by: Dr. Denis <denis@stoglrobotics.de>

…mecanum

destogl

Some changes still needed, not sure if this is working as it should

templates/ros2_control/controller/dummy_chainable_controller.cpp

destogl · 2023-03-21T16:02:00Z

templates/ros2_control/controller/dummy_controller.yaml

      forbidden_interface_name_prefix: null
    }
  }
+  reference_names: {


I am uncertain if this is necessary here or if we should have this in the separate file for the chainable controller.

separate file idea sounds better to me as this is not always the case

@Robotgir are you planing to fix this?

templates/ros2_control/controller/dummy_package_namespace/dummy_chainable_controller.hpp

templates/ros2_control/controller/dummy_package_namespace/dummy_controller.hpp

templates/ros2_control/controller/test_dummy_chainable_controller.cpp

templates/ros2_control/controller/test_dummy_chainable_controller.hpp

templates/ros2_control/controller/test_dummy_chainable_controller.cpp

destogl · 2023-03-21T16:19:25Z

@Robotgir can you test this through one more time, please?

EXPX3 · 2023-04-03T13:44:22Z

@Robotgir can you test this through one more time, please?

@destogl i tested this again an as i said loading controller test alone fails in both standard and chain able cases

mergify · 2023-05-12T07:06:51Z

This pull request is in conflict. Could you fix it @Robotgir?

…from-mecanum

templates/ros2_control/controller/dummy_package_namespace/dummy_controller.hpp

destogl · 2023-05-16T07:05:59Z

@gwalck please also resolve all deprecation warnings from the generated code

destogl

Propose also to change the following:

auto current_ref = input_ref_.readFromRT(); to

auto current_ref = *(reference_.readFromRT());

And all changed following from this. It should clean up the code a bit.

ros-controls/ros2_control#846

gwalck

I have reviewed the changes, added multiple fixes to remove deprecated + fixed all tests

templates/ros2_control/controller/dummy_chainable_controller.cpp

templates/ros2_control/controller/test_dummy_chainable_controller_preceeding.cpp

mergify · 2024-02-26T16:26:40Z

This pull request is in conflict. Could you fix it @Robotgir?

mergify · 2025-02-07T21:16:14Z

This pull request is in conflict. Could you fix it @Robotgir?

GiridharBukka added 6 commits February 21, 2023 10:05

added reference_names and modified cmd and state joint names param

f885b01

updated .cpp and .hpp from mecanum

c7b2e7f

update yaml

4bacc37

update test preceeding load

418af78

update test.hpp

cca54cd

updated tests in templates

06550cf

EXPX3 commented Feb 23, 2023

View reviewed changes

templates/ros2_control/controller/test_dummy_chainable_controller.cpp Show resolved Hide resolved

EXPX3 commented Feb 23, 2023

View reviewed changes

templates/ros2_control/controller/test_dummy_controller_preceeding.cpp Outdated Show resolved Hide resolved

EXPX3 commented Feb 23, 2023

View reviewed changes

templates/ros2_control/controller/dummy_chainable_controller.cpp Show resolved Hide resolved

EXPX3 commented Feb 23, 2023

View reviewed changes

templates/ros2_control/controller/test_dummy_chainable_controller.cpp Outdated Show resolved Hide resolved

EXPX3 and others added 2 commits February 23, 2023 20:17

Apply suggestions from code review

e711a73

corrections

Merge branch 'master' into updating-templates-from-mecanum

76e1cd9

destogl requested changes Feb 23, 2023

View reviewed changes

EXPX3 and others added 11 commits February 24, 2023 01:12

Apply suggestions from code review

98e5b80

Co-authored-by: Dr. Denis <denis@stoglrobotics.de>

correction

baa7cb2

corrections

7510fca

corrections

b4e62b8

correction

de291d4

ran pre-commit

82550f7

added missing test when wrong num of joints

f5c327f

adjusting .hpp w.r.t chainable .hpp

20ceb87

updated regular controller with renaming tests and improvements from …

2fd0dca

…mecanum

updated regular controller with improvements from mecanum

00d6daa

Merge branch 'master' into updating-templates-from-mecanum

c3fcaa8

destogl requested changes Mar 21, 2023

View reviewed changes

Small fiexes to make code more general

f298666

destogl requested a review from muritane March 21, 2023 16:19

EXPX3 mentioned this pull request Mar 23, 2023

Add reference timeout parameter to controllers templates #111

Open

EXPX3 force-pushed the updating-templates-from-mecanum branch from d2911e5 to 3f3e1db Compare March 31, 2023 14:40

mergify bot mentioned this pull request Mar 31, 2023

ran precommit and changed config like the one from ros2_control #118

Closed

GiridharBukka added 4 commits April 3, 2023 13:22

correction

d79cea1

corrections

cdd1779

correction

541215e

corrections

5c485e7

destogl added 3 commits May 16, 2023 06:38

Add Changes from master.

d0c6f70

Merge remote-tracking branch 'origin/master' into updating-templates-…

a971696

…from-mecanum

Correct formatting.

d55376f

destogl reviewed May 16, 2023

View reviewed changes

templates/ros2_control/controller/dummy_package_namespace/dummy_controller.hpp Outdated Show resolved Hide resolved

destogl reviewed May 16, 2023

View reviewed changes

templates/ros2_control/controller/dummy_package_namespace/dummy_controller.hpp Outdated Show resolved Hide resolved

Apply suggestions from code review

24fb0e2

destogl requested a review from gwalck May 16, 2023 05:17

destogl reviewed May 16, 2023

View reviewed changes

gwalck added 8 commits May 17, 2023 21:59

Fixed wrong format when printing size

ce73a02

Fixed deprecated warnings

11601af

Simplified reference access

b65756a

Fixed library path for dummy_controller

5808d19

added missing old_time_stamp test

2981921

Fixed new API of update_reference_from_subscribers

e4316ea

ros-controls/ros2_control#846

Fix NR_CMD_ITFS and NR_STATE_ITFS

362ed82

lint

3d3c03b

gwalck approved these changes Jun 1, 2023

View reviewed changes

templates/ros2_control/controller/dummy_chainable_controller.cpp Outdated Show resolved Hide resolved

templates/ros2_control/controller/test_dummy_chainable_controller_preceeding.cpp Show resolved Hide resolved

Merge branch 'master' into updating-templates-from-mecanum

6b0bbdd

destogl force-pushed the master branch from 4745fce to 2b80753 Compare February 9, 2025 15:21

Conversation

EXPX3 commented Feb 23, 2023 • edited by destogl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Feb 23, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

destogl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

destogl Mar 21, 2023

Choose a reason for hiding this comment

Uh oh!

EXPX3 Mar 31, 2023

Choose a reason for hiding this comment

Uh oh!

destogl May 16, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

destogl commented Mar 21, 2023

Uh oh!

EXPX3 commented Apr 3, 2023

Uh oh!

mergify bot commented May 12, 2023

Uh oh!

Uh oh!

Uh oh!

destogl commented May 16, 2023

Uh oh!

destogl left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gwalck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Feb 26, 2024

Uh oh!

mergify bot commented Feb 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

EXPX3 commented Feb 23, 2023 •

edited by destogl

Loading

destogl left a comment •

edited

Loading