Skip to content

[Bug] Fix maven setting update #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfboys merged 1 commit into from
Jun 21, 2025
Merged

[Bug] Fix maven setting update #4261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ice/src/main/java/org/apache/streampark/console/core/service/impl/SettingServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,11 @@ public boolean update(Setting setting) {
.set(Setting::getSettingValue, value)
.update();

getMavenConfig().updateConfig();

Optional<Setting> optional = Optional.ofNullable(SETTINGS.get(setting.getSettingKey()));
optional.ifPresent(x -> x.setSettingValue(value));

getMavenConfig().updateConfig();
Copy link

Copilot AI Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving getMavenConfig().updateConfig() to after the SETTINGS update ensures that the Maven configuration is updated with the latest settings, which resolves the reported bug.

Copilot uses AI. Check for mistakes.

return true;
} catch (Exception e) {
return false;
Expand Down
Loading