[Bug] Fix maven setting update#4261
Merged
wolfboys merged 1 commit intoapache:devfrom Jun 21, 2025
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug by reordering the update of the Maven configuration so that the in-memory SETTINGS map is updated before calling getMavenConfig().updateConfig().
- The updateConfig() call was moved to after updating the SETTINGS map.
- The ordering change ensures that the Maven configuration reflects the latest setting changes.
| Optional<Setting> optional = Optional.ofNullable(SETTINGS.get(setting.getSettingKey())); | ||
| optional.ifPresent(x -> x.setSettingValue(value)); | ||
|
|
||
| getMavenConfig().updateConfig(); |
There was a problem hiding this comment.
Moving getMavenConfig().updateConfig() to after the SETTINGS update ensures that the Maven configuration is updated with the latest settings, which resolves the reported bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Update "Map<String, Setting> SETTINGS = new ConcurrentHashMap<>();" first, then "getMavenConfig().updateConfig();"
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts