Skip to content

HDDS-11353. Intermittent failure in TestOzoneManagerHAWithStoppedNodes#testOMHAMetrics #9660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivandika3 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

HDDS-11353. Intermittent failure in TestOzoneManagerHAWithStoppedNodes#testOMHAMetrics #9660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...ion-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAWithStoppedNodes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@
import org.apache.hadoop.security.UserGroupInformation;
import org.apache.log4j.Logger;
import org.apache.ozone.test.GenericTestUtils;
import org.apache.ozone.test.tag.Flaky;
import org.apache.ratis.client.RaftClient;
import org.apache.ratis.conf.RaftProperties;
import org.apache.ratis.protocol.ClientId;
Expand Down Expand Up @@ -495,7 +494,6 @@ void testIncrementalWaitTimeWithSameNodeFailover() throws Exception {
omFailoverProxyProvider.getWaitTime());
}

@Flaky("HDDS-11353")
@Test
void testOMHAMetrics() throws Exception {
// Get leader OM
Expand All @@ -513,6 +511,11 @@ void testOMHAMetrics() throws Exception {
getCluster().restartOzoneManager(leaderOM, true);
waitForLeaderToBeReady();

// Do some writes so that the old leader can receive AppendEntries
// which will trigger notifyLeaderChanged, instead of relying on
// AppendEntries
Comment on lines +514 to +516
Copy link
Contributor

@adoroszlai adoroszlai Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I don't think it's worth updating just for this, but if you need to change the patch for any other reason:

Suggested change
// Do some writes so that the old leader can receive AppendEntries
// which will trigger notifyLeaderChanged, instead of relying on
// AppendEntries
// Do some writes so that the old leader can receive AppendEntries
// which will trigger notifyLeaderChanged, instead of relying on
// AppendEntries from heartbeats

Copy link
Contributor Author

@ivandika3 ivandika3 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I missed that. I'll update this if there are any other changes.

setupBucket();

// Get the new leader
OzoneManager newLeaderOM = getCluster().getOMLeader();
String newLeaderOMId = newLeaderOM.getOMNodeId();
Expand Down