HDDS-11353. Intermittent failure in TestOzoneManagerHAWithStoppedNodes#testOMHAMetrics #9660
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toppedNodes#testOMHAMetrics
adoroszlai
reviewed
Jan 22, 2026
Comment on lines
+514
to
+516
| // Do some writes so that the old leader can receive AppendEntries | ||
| // which will trigger notifyLeaderChanged, instead of relying on | ||
| // AppendEntries |
Contributor
There was a problem hiding this comment.
nit: I don't think it's worth updating just for this, but if you need to change the patch for any other reason:
Suggested change
| // Do some writes so that the old leader can receive AppendEntries | |
| // which will trigger notifyLeaderChanged, instead of relying on | |
| // AppendEntries | |
| // Do some writes so that the old leader can receive AppendEntries | |
| // which will trigger notifyLeaderChanged, instead of relying on | |
| // AppendEntries from heartbeats |
adoroszlai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The root cause should be because old leader triggers StateMachine#notifyLeaderChanged and update the HA metrics only when it receives AppendEntries from the leader. Therefore, instead of relying on the AppendEntries from heartbeats, we can simply do some writes so that the old leader will be aware of the new leader.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11353
How was this patch tested?
10x10: https://github.com/ivandika3/ozone/actions/runs/21250244703