FINERACT-1597: Fix validation error for well-formed term deposit chart slabs#5565
Open
airajena wants to merge 1 commit intoapache:developfrom
Open
FINERACT-1597: Fix validation error for well-formed term deposit chart slabs#5565airajena wants to merge 1 commit intoapache:developfrom
airajena wants to merge 1 commit intoapache:developfrom
Conversation
airajena
force-pushed
the
FINERACT-1597/term-deposit-chart-slab-validation
branch
from
87d0f12 to
31de373
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a validation bug where updating/creating term deposit products with valid chart slabs could fail with:
validation.msg.recurringdeposit.chart.slabs.range.end.incorrectThe issue appeared for well-formed terminal slabs (for example:
fromPeriod=0,toPeriod=3).Root Cause
Chart slab validation in
InterestRateChart.validateChartSlabs(...)treated certain end-range values as invalid even when there was no subsequent slab requiring continuity validation.Changes
Scope
Validation
Executed locally:
./gradlew :fineract-savings:test --tests org.apache.fineract.portfolio.interestratechart.domain.InterestRateChartValidationTest./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTestRisk
Low.
Changes are localized to chart validation logic + one focused regression test.