FINERACT-1597: Allow terminal period slab end values

Author: airajena

fineract-savings/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChart.java

@@ -177,9 +177,6 @@ public void validateChartSlabs(DataValidatorBuilder baseDataValidator) {
 
                     }
                 }
-            } else if (iSlabs.slabFields().isNotProperPriodEnd()) {
-                baseDataValidator.failWithCodeNoParameterAddedToErrorCode("chart.slabs.range.end.incorrect", iSlabs.slabFields().toPeriod(),
-                        iSlabs.slabFields().getAmountRangeTo());
             }
         }
     }

fineract-savings/src/main/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartSlabFields.java

@@ -247,11 +247,6 @@ public static boolean isNotProperPeriodStart(InterestRateChartSlabFields interes
                 && !(interestRateChartSlabFields.fromPeriod.equals(1) || interestRateChartSlabFields.fromPeriod.equals(0));
     }
 
-    public boolean isNotProperPriodEnd() {
-        return !(this.toPeriod == null && this.amountRangeTo == null);
-
-    }
-
     public boolean isRateChartOverlapping(final InterestRateChartSlabFields that, final boolean isPrimaryGroupingByAmount) {
         boolean isPeriodOverLapping = isPeriodOverlapping(that);
         boolean isAmountOverLapping = isAmountOverlapping(that);

fineract-savings/src/test/java/org/apache/fineract/portfolio/interestratechart/domain/InterestRateChartValidationTest.java

@@ -20,11 +20,15 @@
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
+import java.math.BigDecimal;
+import java.time.LocalDate;
 import java.util.ArrayList;
 import java.util.List;
 import org.apache.fineract.infrastructure.core.data.ApiParameterError;
 import org.apache.fineract.infrastructure.core.data.DataValidatorBuilder;
+import org.apache.fineract.portfolio.savings.SavingsPeriodFrequencyType;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
@@ -71,4 +75,22 @@ public void testGapBetweenRangesValidation() {
         // Check that arguments are present
         assertFalse(actualError.getArgs().isEmpty());
     }
+
+    @Test
+    public void testSinglePeriodChartSlabWithExplicitEndDoesNotFailValidation() {
+        InterestRateChartFields chartFields = InterestRateChartFields.createNew("chart", "chart", LocalDate.of(2022, 1, 1),
+                LocalDate.of(2022, 12, 31), false);
+        InterestRateChart chart = InterestRateChart.createNew(chartFields, List.of());
+
+        InterestRateChartSlabFields slabFields = InterestRateChartSlabFields.createNew("Level 1", SavingsPeriodFrequencyType.MONTHS, 0, 3,
+                null, null, new BigDecimal("12"), "USD");
+        InterestRateChartSlab.createNew(slabFields, chart);
+
+        DataValidatorBuilder validator = new DataValidatorBuilder(dataValidationErrors).resource("savings.interestRateChart")
+                .parameter("slabs");
+        chart.validateChartSlabs(validator);
+
+        assertTrue(dataValidationErrors.isEmpty(),
+                "Expected no validation error for a single well-formed period slab with explicit toPeriod");
+    }
 }

integration-tests/src/test/java/org/apache/fineract/integrationtests/SavingsAccountsExternalIdTest.java

@@ -19,8 +19,6 @@
 package org.apache.fineract.integrationtests;
 
 import java.math.BigDecimal;
-import java.time.LocalDate;
-import java.time.ZoneId;
 import java.time.format.DateTimeFormatter;
 import java.util.UUID;
 import org.apache.fineract.client.models.DeleteSavingsAccountsAccountIdResponse;
@@ -33,6 +31,7 @@
 import org.apache.fineract.client.models.SavingsAccountData;
 import org.apache.fineract.client.util.Calls;
 import org.apache.fineract.integrationtests.client.IntegrationTest;
+import org.apache.fineract.integrationtests.common.Utils;
 import org.apache.fineract.integrationtests.common.savings.SavingsTestLifecycleExtension;
 import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
@@ -48,7 +47,7 @@ public class SavingsAccountsExternalIdTest extends IntegrationTest {
     public static final String EXTERNAL_ID = UUID.randomUUID().toString();
     private final String dateFormat = "dd MMMM yyyy";
     private final String locale = "en";
-    private final String formattedDate = LocalDate.now(ZoneId.of("UTC")).format(DateTimeFormatter.ofPattern(dateFormat));
+    private final String formattedDate = Utils.getLocalDateOfTenant().format(DateTimeFormatter.ofPattern(dateFormat));
 
     @Test
     @Order(1)