Conversation
typed-ast is not maintained anymore, and builds with newer python
versions raises:
ast27/Custom/../Include/compile.h:12:12: error: unknown type name ‘PyFutureFeatures’
12 | PyAPI_FUNC(PyFutureFeatures *) PyFuture_FromAST(struct _mod *, const char *);
The minimum black version with 966baaa is 21.4b0,
but due to black-docs min version with the same fix (a24ed2d, 1.13.0),
set as 22.12.0.
Signed-off-by: Jorge Marques <[email protected]>
Test Results1 676 tests ±0 442 ✅ ±0 12m 1s ⏱️ -1s For more details on these failures, see this check. Results for commit 820b015. ± Comparison against base commit 147403f. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Collaborator
|
Yeah newer black versions change the default style so when we update everything is gunna get touched. Might switch to ruff over black for speed reasons as well. Ideally we can get repo level changes into 1 commit so git blame and related can filter more easily |
This was referenced Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
typed-ast is not maintained anymore, and builds with newer python versions raise:
The minimum black version with 966baaais 21.4b0,
but due to black-docs min version with the same fix (a24ed2d, 1.13.0), set as 22.12.0.
Ready for review if ci passes, don't know if between 19.10b0->22.12.0 there are breaking changes that affects the intended pre-commit hooks behavior.
From CI run
https://github.com/analogdevicesinc/pyadi-iio/actions/runs/14374856506/job/40304790945?pr=660
seems to install with all py versions, but touches all many files.
ex diff (pretty-much running on all files instead of touched files. due to pre-commit run --all-files 2> /dev/null, is this intended behavior?
Maybe
git diff --name-only $base_sha..$head_sha | xargs pre-commit run --filesis more suitable, base_sha, head_sha setup suggestion, or strictierpre-commit run --from-ref $base_ref --to-ref $head_sha)Type of change
Please delete options that are not relevant.
How has this been tested?
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: