Conversation
Test Results1 676 tests ±0 442 ✅ ±0 11m 58s ⏱️ -2s For more details on these failures, see this check. Results for commit c829354. ± Comparison against base commit 6ad6c49. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
4cfb284 to
7e64edd
Compare
tfcollins
requested changes
Apr 14, 2025
Collaborator
tfcollins
left a comment
There was a problem hiding this comment.
Please run the linter precommit tool
Some attributes are fetched from the first channel, and if multichip,
first device:
* ad9081: []
* ad9081_mc: {'dev1': [...], 'dev2': [...],}
Due to the type change, examples/QuadMxFE_dual_example.py was broken.
Use the method overwrite to fix the type and behavior.
Signed-off-by: Jorge Marques <[email protected]>
Contributor
Author
|
Hi, I run again with the exact black version the differences from the updated #660 to the current version (broken for newer python) are pretty much the force push diff https://github.com/analogdevicesinc/pyadi-iio/compare/7e64edd25d2e38956f9d6ad254510402c2deebf7..c829354697aa6ff7507775a3850efe02ee7ffd89 |
|
Generated documentation for this PR is available at Link |
tfcollins
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some attributes are fetched from the first channel, and if multichip, from the first device:
Due to the type change, examples/QuadMxFE_dual_example.py was broken.
Use the method overwrite to fix the type and behavior.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: