Gutter Hover tooltip by mkslanc · Pull Request #5872 · ajaxorg/ace

mkslanc · 2025-09-15T13:26:37Z

Issue #, if available:

Description of changes:

make gutter tooltip to work similar HoverTooltip

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

No backwards incompatible changes were made to Ace's public interface which is defined through the main typings file (ace.d.ts) and its references:

…n position logic.

…de, and improve positioning logic.

… to improve handling and positioning.

github-actions · 2025-09-29T11:09:59Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2025-09-29T17:34:11Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

…d alignment and consistency.

github-actions · 2025-09-30T13:59:30Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2025-10-06T09:40:12Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

… anchor metrics, and improve code clarity.

github-actions · 2025-10-06T15:24:36Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2025-10-07T13:43:53Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2025-10-07T14:10:04Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

…tants, replace `const` with `var` for consistency, and adjust destroy logic.

github-actions · 2025-10-07T14:12:08Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

codecov · 2025-10-07T14:51:58Z

Codecov Report

❌ Patch coverage is 94.82759% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.88%. Comparing base (8f32aab) to head (670086f).
⚠️ Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
src/lib/dom.js	77.27%	5 Missing ⚠️
src/mouse/default_gutter_handler.js	95.45%	3 Missing ⚠️
src/keyboard/gutter_handler.js	80.00%	1 Missing ⚠️
src/keyboard/gutter_handler_test.js	98.00%	1 Missing ⚠️
src/mouse/default_gutter_handler_test.js	97.22%	1 Missing ⚠️
src/tooltip.js	97.87%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5872      +/-   ##
==========================================
- Coverage   87.89%   87.88%   -0.01%     
==========================================
  Files         622      622              
  Lines       46441    46478      +37     
  Branches     7609     7614       +5     
==========================================
+ Hits        40821    40849      +28     
- Misses       5620     5629       +9

Flag	Coverage Δ
unittests	`87.88% <94.82%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nightwing · 2025-10-09T08:01:20Z

ace-internal.d.ts

        select?: () => void
        $lastScroll?: { t: number, vx: number, vy: number, allowed: number }
        selectEnd?: () => void
+        tooltip?: Ace.GutterTooltip


why do we need to add this as public property, don't we have it as annotationTooltip already?

nightwing · 2025-10-09T10:45:12Z

src/mouse/default_gutter_handler_test.js

        assert.notOk(/ace_security_fold/.test(firstLineGutterElement.className));
        assert.ok(/ace_warning_fold/.test(firstLineGutterElement.className));
    },
-    "test: sets position correctly when tooltipFollowsMouse false" : function(done) {


Why this was removed?

This test was specifically to test tooltip mode when tooltipFollowsMouse is false; now we removed this option, so all other tests are checking quite the same.

nightwing · 2025-10-09T10:47:00Z

src/tooltip.js

        editor.on("mousedown", this.hide);
-        editor.renderer.getMouseEventTarget().addEventListener("mouseout", this.onMouseOut, true);
+        var target = editor.renderer.getMouseEventTarget();
+        if (target && typeof target.removeEventListener === "function") {


why is this needed?

nightwing · 2025-10-09T10:47:41Z

src/tooltip.js

-                || isMousePressed
-                || this.isOutsideOfText(this.lastEvent)
-            ) {
+            if (!this.range || !this.range.contains(pos.row, pos.column) || isMousePressed || this.isOutsideOfText(


please revert unrelated formatting changes like this.

nightwing · 2025-10-09T10:51:33Z

src/tooltip.js

+     * @param {{point:{pageX:number,pageY:number},rect?:{top:number,right:number,bottom:number,left:number,width:number,height:number}}} anchor
+     * @param {Range} [range]
+     */
+    $setPosition(editor, anchor, range) {


this looks a bit wrong, point information is contained in rect, and shouldPlaceAbove does not need to be overridden in gutterTooltip.

…of markers, and enhance code readability.

github-actions · 2025-10-09T14:05:16Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

…ype definitions, and adjust related logic for consistency and clarity.

github-actions · 2025-10-09T17:17:03Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2025-10-09T19:43:02Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2025-10-13T14:45:08Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2025-10-13T20:35:09Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

github-actions · 2025-10-13T20:58:44Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

reverts ajaxorg#5853

github-actions · 2025-10-13T21:01:44Z

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

mkslanc added 7 commits September 10, 2025 13:35

WIP: gutter hover tooltip based on hover tooltip

26f4410

Refactor gutter tooltip to reuse hover tooltip functionality and alig…

2ba3927

…n position logic.

Adjust gutter tooltip offsets and ensure absolute positioning.

34193b4

refactor gutter tooltip handling: unify hide method, remove unused co…

e050f62

…de, and improve positioning logic.

remove tooltipFollowsMouse option in default gutter handler (for now)

a06f18e

Merge remote-tracking branch 'origin/master' into gutter-tooltip

c952559

remove tooltipFollowsMouse option and refactor gutter tooltip logic…

145fd4b

… to improve handling and positioning.

fix tests

732ed80

refactor gutter tooltip constructor and positioning logic for improve…

8dd2fe0

…d alignment and consistency.

fix tooltip positioning logic

171fdff

refactor gutter tooltip positioning logic to enhance alignment, reuse…

8237ee6

… anchor metrics, and improve code clarity.

fix more tests

1d6d3b9

mkslanc marked this pull request as ready for review October 7, 2025 14:10

mkslanc changed the title ~~WIP: Gutter Hover tooltip~~ Gutter Hover tooltip Oct 7, 2025

refactor gutter tooltip: improve type definitions, remove unused cons…

47a6321

…tants, replace `const` with `var` for consistency, and adjust destroy logic.

mkslanc force-pushed the gutter-tooltip branch from 7c57333 to 47a6321 Compare October 7, 2025 14:11

nightwing reviewed Oct 9, 2025

View reviewed changes

refactor tooltip logic: improve $setPosition method, update handling …

2e764d0

…of markers, and enhance code readability.

refactor tooltip references: rename tooltip to $tooltip, update t…

f277636

…ype definitions, and adjust related logic for consistency and clarity.

cleanup

28e1060

nightwing approved these changes Oct 9, 2025

View reviewed changes

nightwing mentioned this pull request Oct 10, 2025

Tooltip: incorrect gutter position when wrap and tooltipFollowsMouse: false (throws TypeError: can't access property "getBoundingClientRect", gutterElement is null) #5878

Closed

nightwing force-pushed the gutter-tooltip branch from 9a0c6d6 to 98c936d Compare October 13, 2025 20:35

nightwing force-pushed the gutter-tooltip branch from 98c936d to 7e54b76 Compare October 13, 2025 20:58

Use position fixed to prevent tooltip being cropped to parent node

670086f

reverts ajaxorg#5853

nightwing force-pushed the gutter-tooltip branch from 7e54b76 to 670086f Compare October 13, 2025 21:01

maria-raluca-st merged commit d1a93fc into ajaxorg:master Oct 17, 2025
3 of 4 checks passed

davidjb mentioned this pull request Oct 24, 2025

ace-builds: dom.$fixPositionBug is not a function #5883

Closed

Conversation

mkslanc commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

github-actions bot commented Sep 30, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

codecov bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nightwing Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

nightwing Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

mkslanc Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

nightwing Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

nightwing Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

mkslanc Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

nightwing Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 9, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mkslanc commented Sep 15, 2025 •

edited

Loading

codecov bot commented Oct 7, 2025 •

edited

Loading