ace-builds: `dom.$fixPositionBug` is not a function

[davidjb]

Describe the bug

When attempting to display a tooltip, the exception Uncaught TypeError: dom.$fixPositionBug is not a function is thrown from https://github.com/ajaxorg/ace-builds/blob/v1.43.4/src/ext-language_tools.js#L1310.

Expected Behavior

Exception not to throw, tooltip to function correctly.

Current Behavior

Uncaught TypeError: dom.$fixPositionBug is not a function
    tryShow ext-language_tools.js:1310
    $updatePopupPosition ext-language_tools.js:1726
    call ace.js:452
    $onPopupChange ext-language_tools.js:1641

Source:
https://github.com/ajaxorg/ace-builds/blob/v1.43.4/src/ext-language_tools.js#L1310

Reproduction Steps

import ace from 'ace-builds/src-noconflict/ace';

const { HoverTooltip } = ace.require('ace/tooltip');
const tooltip = new HoverTooltip();
// throws trying to call undefined dom.$fixPositionBug
tooltip.showForRange(editor, new Range(0, 0, 0, 0), document.createElement('div'), null);

Possible Solution

Searching the ace-builds repo via https://github.com/search?q=repo%3Aajaxorg%2Face-builds%20fixpositionbug&type=code it appears this function isn't present here in v1.43.4 but was added very recently into ace via #5872. Does ace-builds need further updating?

Pinning to v1.43.3 allows Ace works around the issue.

Additional Information/Context

No response

Ace Version / Browser / OS / Keyboard layout

1.43.4

[marinsokol5]

@nightwing and @mkslanc can you take a look

[nightwing]

It is strange that github search doesn't find the function, but it is present at https://github.com/ajaxorg/ace-builds/blob/v1.43.4/src/ace.js#L713

Can it be that you are getting ace.js and language-tools from different versions? because i am unable to reproduce this issue on https://mkslanc.github.io/ace-playground/#typescript-language-service or on this

[davidjb]

Thanks for clarifying @nightwing. After a bit of digging, I found my yarn.lock somehow had separate resolutions blocks for ace-builds@1.43.4 (my package's version) and ace-builds@^1.36.3 (originally from react-ace), which looked like:

ace-builds@^1.43.3:
  version "1.43.3"

ace-builds@^1.36.3:
  version "1.42.0"

(other properties omitted for clarity)

This was cause of the issue. Trying to re-run yarn didn't change the lockfile so I manually removed both blocks from yarn.lock and re-ran yarn.

This caused the blocks to be recreated together as:

ace-builds@^1.36.3, ace-builds@^1.43.4:
  version "1.43.4"

My builds are succeeding fine, only 1 version of Ace is present, and tooltips displaying correctly. I really appreciate the help and for pointing me in the right direction 👍

[CHaiz15]

Thanks for clarifying @nightwing. After a bit of digging, I found my yarn.lock somehow had separate resolutions blocks for ace-builds@1.43.4 (my package's version) and ace-builds@^1.36.3 (originally from react-ace), which looked like:

ace-builds@^1.43.3:
version "1.43.3"

ace-builds@^1.36.3:
version "1.42.0"
(other properties omitted for clarity)

This was cause of the issue. Trying to re-run yarn didn't change the lockfile so I manually removed both blocks from yarn.lock and re-ran yarn.

This caused the blocks to be recreated together as:

ace-builds@^1.36.3, ace-builds@^1.43.4:
version "1.43.4"
My builds are succeeding fine, only 1 version of Ace is present, and tooltips displaying correctly. I really appreciate the help and for pointing me in the right direction 👍

I had the exact same issue that was also causing a very confusing double typing bug. Luckily this fixed both issues! Thanks for posting this 🙌