Merged
Conversation
…ropIsPseudolattice` into the the `Base` file
…ing similar modules
Draft
…; add module `PseudolatticeTheory` which export them
Contributor
Author
|
@mortberg @ecavallo @mzeuner I was wondering whether this PR and #1271 might be reviewed when convenient. |
Collaborator
|
This also looks good to me, except for the conflict. Can you fix the conflict and ping me again and I'll merge it? |
Contributor
Author
|
@mortberg I fixed the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the
Pseudolatticemodule.It introduces the definition of equivalences between pseudolattices, following the pattern used in the other order structures, and adds a basic
Propertiesmodule containing the results that seem most generally useful.