You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reopening #1268.
I also added 0<+ to Data.Int.Order, as I noticed that the corresponding property for rationals uses the same name in the Data.Rationals.Order module
@mortberg Thank you again!
Once #1272 will be merged, the only remaining open PR from me will be #1280, which will no longer depend on other PRs.
I know it is quite large, and reviewing the latest changes (in particular the Fast/Int/Order module) may take some time, so I am not expecting it to be merged immediately. Still, I would appreciate if it could be reviewed in the near future
@mortberg Thank you again! Once #1272 will be merged, the only remaining open PR from me will be #1280, which will no longer depend on other PRs. I know it is quite large, and reviewing the latest changes (in particular the Fast/Int/Order module) may take some time, so I am not expecting it to be merged immediately. Still, I would appreciate if it could be reviewed in the near future
Perfect! I will try to take a look at #1280 tomorrow now that I finally have some time to look at PRs :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #1268.
I also added
0<+toData.Int.Order, as I noticed that the corresponding property for rationals uses the same name in theData.Rationals.Ordermodule