Skip to content

Instances for Pseudolattice and OrderedCommRing#1271

Merged
mortberg merged 1 commit intoagda:masterfrom
LorenzoMolena:ocr+pl-instances'
Feb 17, 2026
Merged

Instances for Pseudolattice and OrderedCommRing#1271
mortberg merged 1 commit intoagda:masterfrom
LorenzoMolena:ocr+pl-instances'

Conversation

@LorenzoMolena
Copy link
Contributor

Reopening #1268.
I also added 0<+ to Data.Int.Order, as I noticed that the corresponding property for rationals uses the same name in the Data.Rationals.Order module

@mortberg mortberg merged commit 77dc5aa into agda:master Feb 17, 2026
1 check passed
@mortberg
Copy link
Collaborator

Looks good to me! Sorry for the slow merge... Is there anything else that you want merged?

@LorenzoMolena
Copy link
Contributor Author

@mortberg Thank you again!
Once #1272 will be merged, the only remaining open PR from me will be #1280, which will no longer depend on other PRs.
I know it is quite large, and reviewing the latest changes (in particular the Fast/Int/Order module) may take some time, so I am not expecting it to be merged immediately. Still, I would appreciate if it could be reviewed in the near future

@mortberg
Copy link
Collaborator

@mortberg Thank you again! Once #1272 will be merged, the only remaining open PR from me will be #1280, which will no longer depend on other PRs. I know it is quite large, and reviewing the latest changes (in particular the Fast/Int/Order module) may take some time, so I am not expecting it to be merged immediately. Still, I would appreciate if it could be reviewed in the near future

Perfect! I will try to take a look at #1280 tomorrow now that I finally have some time to look at PRs :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants