fix: Replace console.log() with debug library in HTTPFileLoader#1125
Merged
mttrbrts merged 1 commit intoaccordproject:mainfrom Feb 13, 2026
Merged
Conversation
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Contributor
Author
|
@ekarademir @dselman @mttrbrts a review will be appreciated! |
mttrbrts
approved these changes
Feb 13, 2026
Member
mttrbrts
left a comment
There was a problem hiding this comment.
Approved. Can you port this change to the v4.0.0 branch too, please?
Contributor
Author
|
Yes sure @mttrbrts, I'd be happy to do so! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The HTTPFileLoader.load() method in
concerto-utilusesconsole.log()to output the request URL during file loading. This causes unwanted console spam , security concerns (URLs may contain sensitive paths) and takes up unnecessary terminal space.Solution
Replace
console.log(requestUrl)withdebug('loading', requestUrl), utilizing the debug library that is already imported in the fileconcerto-utilChanges:
File:
packages/concerto-util/lib/loaders/httpfileloader.jsLine 17: added debug import (
const debug = require('debug')('concerto:HTTPFileLoader');)Line 60: Changed
console.log(requestUrl);→debug('loading', requestUrl);Why these changes were required:
concerto-utilTesting