fix: replace console.warn() with debug library in concerto-core#1133
Open
23harshitkumar wants to merge 7 commits intoaccordproject:v4.0.0from
Open
fix: replace console.warn() with debug library in concerto-core#113323harshitkumar wants to merge 7 commits intoaccordproject:v4.0.0from
23harshitkumar wants to merge 7 commits intoaccordproject:v4.0.0from
Conversation
Contributor
Author
|
@ekarademir @mttrbrts the PR is ready for a review! |
Member
|
I like the change, but let's target this to v4.0.0? |
Contributor
Author
|
@mttrbrts I have a question for this repo. Am I supposed to focus all my new PRs to the v4.0.0 branch? |
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
55f4d73 to
932f82c
Compare
Contributor
Author
|
@mttrbrts I changed the base branch from main to v4! Conflicts resolved and rebased onto v4.0.0! Tests pass locally, but I see CI is failing. Is this expected for the v4.0.0 branch or should I investigate further? |
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: N/A
Summary:
Replace remaining
console.warn()calls with the debug library inconcerto-core, following the same pattern established in #1125 (HTTPFileLoader).Changes:
basemodelmanager.js: Replaceconsole.warnfor invalid metamodel warnings withdebug('concerto:BaseModelManager')(already imported)jsonpopulator.js: Adddebug('concerto:JSONPopulator')import and replaceconsole.warnfor TZ environment variable warningsmodelmanager.js(test) : Update comment to reflect new behavior.Why these changes:
console.warn()pollutes console output in production environments, CI pipelines, etc. The debug library allows users to opt-in to these warnings viaDEBUG=concerto:*when needed.Testing:
(modelmanager.js + jsonpopulator.js).