Skip to content

fix: replace console.warn() with debug library in concerto-core#1133

Open
23harshitkumar wants to merge 7 commits intoaccordproject:v4.0.0from
23harshitkumar:fix/replace-console-warn-with-debug
Open

fix: replace console.warn() with debug library in concerto-core#1133
23harshitkumar wants to merge 7 commits intoaccordproject:v4.0.0from
23harshitkumar:fix/replace-console-warn-with-debug

Conversation

@23harshitkumar
Copy link
Contributor

@23harshitkumar 23harshitkumar commented Feb 14, 2026

Fixes: N/A

Summary:

Replace remaining console.warn() calls with the debug library in concerto-core, following the same pattern established in #1125 (HTTPFileLoader).

Changes:

  • basemodelmanager.js : Replace console.warn for invalid metamodel warnings with debug('concerto:BaseModelManager') (already imported)

  • jsonpopulator.js : Add debug('concerto:JSONPopulator') import and replace console.warn for TZ environment variable warnings

  • modelmanager.js (test) : Update comment to reflect new behavior.

Why these changes:

console.warn() pollutes console output in production environments, CI pipelines, etc. The debug library allows users to opt-in to these warnings via DEBUG=concerto:* when needed.

Testing:

  • All 149 tests pass (modelmanager.js + jsonpopulator.js).

@23harshitkumar
Copy link
Contributor Author

@ekarademir @mttrbrts the PR is ready for a review!

@mttrbrts
Copy link
Member

I like the change, but let's target this to v4.0.0?

@23harshitkumar
Copy link
Contributor Author

23harshitkumar commented Feb 15, 2026

@mttrbrts I have a question for this repo. Am I supposed to focus all my new PRs to the v4.0.0 branch?
Is this because we're primarily working and focusing on the v4.0.0 for now?

@23harshitkumar 23harshitkumar changed the base branch from main to v4.0.0 February 15, 2026 18:23
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
@23harshitkumar 23harshitkumar force-pushed the fix/replace-console-warn-with-debug branch from 55f4d73 to 932f82c Compare February 15, 2026 18:49
@23harshitkumar
Copy link
Contributor Author

@mttrbrts I changed the base branch from main to v4!

Conflicts resolved and rebased onto v4.0.0! Tests pass locally, but I see CI is failing. Is this expected for the v4.0.0 branch or should I investigate further?

Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Signed-off-by: Harshit Kumar <10harshitkumar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants