docs(website): clear all TS errors in React samples and add CI typecheck#13213
Merged
docs(website): clear all TS errors in React samples and add CI typecheck#13213
Conversation
… typecheck All 83 TypeScript errors in the React sample.tsx files have been fixed. Since samples are loaded via raw-loader as plain text, broken types were invisible during the website build. A new `typecheck:samples` script and CI step now run `tsc --noEmit` against the samples so regressions are caught on every PR.
Sample sync reminderHTML sample changed but React sample (
React sample changed but HTML sample (
Please keep both samples in sync, or ignore if the change does not apply to both. |
ilhan007
changed the title
Collaborator
|
🚀 Deployed on https://pr-13213--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sample.tsxfiles. These errors accumulated silently because samples are loaded viaraw-loaderas plain text — even completely broken syntax compiles fine during the website build.typecheck:samplesCI step to the website workflow so that any new TypeScript error in a React sample will fail the PR check going forward.What was fixed
UI5CustomEventtype mismatches)min-date,max-dateasDateinstead of string)monaco-ui5-types.d.tsCI change
A new step "Typecheck React samples" runs
tsc --noEmitagainstdocs/_samples/tsconfig.jsonafter the website build:Test plan
yarn typecheck:samplespasses locally with 0 errors