Skip to content

Commit 810c55d

Browse files
ilhan007ilhan007
authored
docs(website): clear all TS errors in React samples and add CI typecheck (#13213)
fix(website): clear all TypeScript errors in React samples and add CI typecheck All 83 TypeScript errors in the React sample.tsx files have been fixed. Since samples are loaded via raw-loader as plain text, broken types were invisible during the website build. A new `typecheck:samples` script and CI step now run `tsc --noEmit` against the samples so regressions are caught on every PR.
1 parent 979f966 commit 810c55d

File tree

62 files changed

+156
-118
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+156
-118
lines changed

‎.github/workflows/ci-test-website.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,6 @@ jobs:
2121
export NODE_OPTIONS="--max_old_space_size=4096"
2222
yarn install
2323
yarn ci:deploy:nightly
24+
25+
- name: Typecheck Samples
26+
run: yarn workspace @ui5/webcomponents-website typecheck:samples

‎packages/website/docs/_samples/ai/Input/Basic/sample.tsx‎

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,18 @@ const SAMPLE_TEXTS: Record<string, string> = {
2020
summarized: "Driving innovation creatively.",
2121
};
2222

23-
const INITIAL_MENU_CONFIG = [
23+
type Config = {
24+
text?: string;
25+
action?: string;
26+
processingLabel?: string;
27+
completedLabel?: string;
28+
textKey?: string;
29+
slot?: string;
30+
children?: Config[];
31+
separator?: boolean;
32+
};
33+
34+
const INITIAL_MENU_CONFIG: Array<Config> = [
2435
{
2536
text: "Generate",
2637
action: "generate",
@@ -31,7 +42,7 @@ const INITIAL_MENU_CONFIG = [
3142
},
3243
];
3344

34-
const FULL_MENU_CONFIG = [
45+
const FULL_MENU_CONFIG: Array<Config> = [
3546
{
3647
text: "Regenerate",
3748
action: "regenerate",
@@ -125,7 +136,7 @@ function App() {
125136
const [currentVersion, setCurrentVersion] = useState(0);
126137
const [totalVersions, setTotalVersions] = useState(0);
127138
const [promptDescription, setPromptDescription] = useState("");
128-
const [menuConfig, setMenuConfig] = useState(INITIAL_MENU_CONFIG);
139+
const [menuConfig, setMenuConfig] = useState<Config[]>(INITIAL_MENU_CONFIG);
129140

130141
const versionHistoryRef = useRef<VersionEntry[]>([]);
131142
const currentIndexRef = useRef(0);

‎packages/website/docs/_samples/compat/Table/Grouping/sample.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,13 @@ function App() {
2323
</CompatTableColumn>
2424
<CompatTableColumn
2525
slot="columns"
26-
minWidth="500"
26+
minWidth={500}
2727
popinText="Supplier"
2828
demandPopin
2929
>
3030
<Label>Supplier</Label>
3131
</CompatTableColumn>
32-
<CompatTableColumn slot="columns" minWidth="500">
32+
<CompatTableColumn slot="columns" minWidth={500}>
3333
<Label>Date Of Foundation</Label>
3434
</CompatTableColumn>
3535

‎packages/website/docs/_samples/compat/Table/GrowingOnScroll/sample.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ function App() {
157157
<div style={{ height: "200px", overflow: "scroll" }}>
158158
<CompatTable
159159
growing={growing}
160-
busyDelay="0"
160+
busyDelay={0}
161161
busy={busy}
162162
onLoadMore={handleLoadMore}
163163
>

‎packages/website/docs/_samples/compat/Table/MultipleSelection/sample.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function App() {
1919
</CompatTableColumn>
2020
<CompatTableColumn
2121
slot="columns"
22-
minWidth="600"
22+
minWidth={600}
2323
popinText="Supplier"
2424
demandPopin
2525
popinDisplay="Inline"
@@ -28,7 +28,7 @@ function App() {
2828
</CompatTableColumn>
2929
<CompatTableColumn
3030
slot="columns"
31-
minWidth="800"
31+
minWidth={800}
3232
popinText="Dimensions"
3333
demandPopin
3434
popinDisplay="Inline"
@@ -37,7 +37,7 @@ function App() {
3737
</CompatTableColumn>
3838
<CompatTableColumn
3939
slot="columns"
40-
minWidth="800"
40+
minWidth={800}
4141
popinText="Weight"
4242
demandPopin
4343
popinDisplay="Inline"

‎packages/website/docs/_samples/compat/Table/SingleSelection/sample.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function App() {
1919
</CompatTableColumn>
2020
<CompatTableColumn
2121
slot="columns"
22-
minWidth="600"
22+
minWidth={600}
2323
popinText="Supplier"
2424
demandPopin
2525
popinDisplay="Inline"
@@ -28,7 +28,7 @@ function App() {
2828
</CompatTableColumn>
2929
<CompatTableColumn
3030
slot="columns"
31-
minWidth="800"
31+
minWidth={800}
3232
popinText="Dimensions"
3333
demandPopin
3434
popinDisplay="Inline"
@@ -37,7 +37,7 @@ function App() {
3737
</CompatTableColumn>
3838
<CompatTableColumn
3939
slot="columns"
40-
minWidth="800"
40+
minWidth={800}
4141
popinText="Weight"
4242
demandPopin
4343
popinDisplay="Inline"

‎packages/website/docs/_samples/compat/Table/StickyHeader/sample.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,20 @@ function App() {
1818
<CompatTableColumn slot="columns">
1919
<Text>Product</Text>
2020
</CompatTableColumn>
21-
<CompatTableColumn slot="columns" minWidth="800">
21+
<CompatTableColumn slot="columns" minWidth={800}>
2222
<Text>Supplier</Text>
2323
</CompatTableColumn>
2424
<CompatTableColumn
2525
slot="columns"
26-
minWidth="600"
26+
minWidth={600}
2727
popinText="Dimensions"
2828
demandPopin
2929
>
3030
<Text>Dimensions</Text>
3131
</CompatTableColumn>
3232
<CompatTableColumn
3333
slot="columns"
34-
minWidth="600"
34+
minWidth={600}
3535
popinText="Weight"
3636
demandPopin
3737
>

‎packages/website/docs/_samples/fiori/DynamicSideContent/Basic/sample.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function App() {
2323
<div style={{ width: "1000px", overflowX: "scroll" }}>
2424
<DynamicSideContent sideContentVisibility="AlwaysShow">
2525
<div>
26-
<Title level="h1">Main Content</Title>
26+
<Title level="H1">Main Content</Title>
2727
<p className="text">
2828
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc ex
2929
mi, elementum et ante commodo, semper sollicitudin magna. Sed
@@ -37,7 +37,7 @@ function App() {
3737
</p>
3838
</div>
3939
<div slot="sideContent">
40-
<Title level="h1">Side Content</Title>
40+
<Title level="H1">Side Content</Title>
4141
<p className="text">
4242
Morbi lorem libero, imperdiet id condimentum ac, tempor ut velit.
4343
Integer a laoreet sem. Nunc at sagittis nisi. Sed placerat diam eu

‎packages/website/docs/_samples/fiori/DynamicSideContent/EqualSplit/sample.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function App() {
2626
equalSplit={true}
2727
>
2828
<div>
29-
<Title level="h1">Main Content</Title>
29+
<Title level="H1">Main Content</Title>
3030
<p className="text">
3131
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc ex
3232
mi, elementum et ante commodo, semper sollicitudin magna. Sed
@@ -40,7 +40,7 @@ function App() {
4040
</p>
4141
</div>
4242
<div slot="sideContent">
43-
<Title level="h1">Side Content</Title>
43+
<Title level="H1">Side Content</Title>
4444
<p className="text">
4545
Morbi lorem libero, imperdiet id condimentum ac, tempor ut velit.
4646
Integer a laoreet sem. Nunc at sagittis nisi. Sed placerat diam eu

‎packages/website/docs/_samples/fiori/DynamicSideContent/SideContentPosition/sample.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function App() {
2626
sideContentPosition="Start"
2727
>
2828
<div>
29-
<Title level="h1">Main Content</Title>
29+
<Title level="H1">Main Content</Title>
3030
<p className="text">
3131
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc ex
3232
mi, elementum et ante commodo, semper sollicitudin magna. Sed
@@ -40,7 +40,7 @@ function App() {
4040
</p>
4141
</div>
4242
<div slot="sideContent">
43-
<Title level="h1">Side Content</Title>
43+
<Title level="H1">Side Content</Title>
4444
<p className="text">
4545
Morbi lorem libero, imperdiet id condimentum ac, tempor ut velit.
4646
Integer a laoreet sem. Nunc at sagittis nisi. Sed placerat diam eu

0 commit comments

Comments
 (0)