feat(command): add suggestion providers and their support in argument nodes#2004
Open
SomeYellowGuy wants to merge 4 commits intoPumpkin-MC:masterfrom
Open
feat(command): add suggestion providers and their support in argument nodes#2004SomeYellowGuy wants to merge 4 commits intoPumpkin-MC:masterfrom
SomeYellowGuy wants to merge 4 commits intoPumpkin-MC:masterfrom
Conversation
SomeYellowGuy
changed the title
RoosterBooster007
added
enhancement
SomeYellowGuy
force-pushed
the
add-suggestion-providers
branch
from
fd610a7 to
66caabd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
SuggestionProviders for specific arguments that may require them.suggestsandsuggests_arcmethods can be used on an argument node to add a customSuggestionProviderfor it. This is used quite a lot: some commands that use this include/op,/execute,/bossbar,/scoreboardand/tick.Testing
1to5for the integer argument of/setidletimeout, and it works for the server and the client!