feat(command): implement game profile argument type#2005
Merged
Snowiiii merged 5 commits intoPumpkin-MC:masterfrom Apr 11, 2026
Merged
feat(command): implement game profile argument type#2005Snowiiii merged 5 commits intoPumpkin-MC:masterfrom
Snowiiii merged 5 commits intoPumpkin-MC:masterfrom
Conversation
RoosterBooster007
added
enhancement
Member
|
LGTM. Thank you @SomeYellowGuy :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the game profile argument type with the previously made
EntitySelectors.Note that no
GameProfileSuggestionModeobject was added for this argument (as was in theargs'GameProfileArgumentConsumer) because custom suggestions can be controlled by custom suggestion providers (#2004).Testing
Created the test command locally, which printed the resulting
GameProfiles to the command source, and it works!