Skip to content

Skip Tests for Packages in src/external_dependencies if Folder Exists#14

Merged
JWhitleyWork merged 1 commit intomainfrom
dont-test-external-dependencies
Jan 21, 2026
Merged

Skip Tests for Packages in src/external_dependencies if Folder Exists#14
JWhitleyWork merged 1 commit intomainfrom
dont-test-external-dependencies

Conversation

@JWhitleyWork
Copy link
Member

We shouldn't fail CI jobs because external dependencies fail CI. This checks to see if the workspace contains a src/external_dependencies folder and, if so, skips tests for packages contained in that folder.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the GitHub Actions workflow to skip testing packages located in src/external_dependencies to prevent CI failures from external dependencies. The implementation adds conditional logic to check for the existence of this folder and excludes those packages from testing.

Changes:

  • Add bash shell configuration to the "Run colcon test" step
  • Implement conditional logic to skip packages in src/external_dependencies when running tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JWhitleyWork JWhitleyWork requested a review from dsobek January 21, 2026 17:20
@JWhitleyWork JWhitleyWork merged commit 286ca21 into main Jan 21, 2026
6 checks passed
@JWhitleyWork JWhitleyWork deleted the dont-test-external-dependencies branch January 21, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants