Fix misleading log message in OR_MODE_BITS branch of CompareRunPlanData()#128
Merged
rrivera747 merged 2 commits intorrivera/betterCFORunPlanPrintoutCommentsfrom Mar 9, 2026
Conversation
…_MODE_BITS block Co-authored-by: rrivera747 <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback on adding MARKER index to printouts for opcodes tracking
Fix misleading log message in OR_MODE_BITS branch of CompareRunPlanData()
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OR_MODE_BITSopcode branch inCompareRunPlanData()was emitting a trace message labelled "Found AND line", making it impossible to distinguish AND vs OR opcodes in diagnostic output.Change
cfoInterfaceLib/CFO_Registers.cpp: Corrected log string from"Found AND line"to"Found OR line"in theOR_MODE_BITSblock.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.