Add MARKER index to printouts for easier tracking of opcodes#125
Add MARKER index to printouts for easier tracking of opcodes#125rrivera747 merged 16 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves run plan debugging output by annotating compiled MARKER opcodes with an incrementing index, and adds additional validation/inspection capabilities around run plan BRAM readback. It also adjusts the DTC firmware version-mismatch message to print a more human-readable expected design date.
Changes:
- Number MARKER instructions in the compiler’s binary printout for easier opcode tracking.
- Extend
CFO_Registers::CompareRunPlanDatato optionally collect AND/OR mode masks during readback/validation (and change its mismatches parameter type). - Update DTC design-date mismatch reporting to show a formatted expected design date (with a fallback path).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
dtcInterfaceLib/DTC_Registers.cpp |
Enhances version mismatch message formatting (expected design date) and adds a fallback message path. |
cfoInterfaceLib/CFO_Registers.h |
Changes CompareRunPlanData signature to use std::optional<std::reference_wrapper<...>> and adds optional mask outputs. |
cfoInterfaceLib/CFO_Registers.cpp |
Implements optional mask extraction during run plan validation and updates mismatch handling for the new optional API. |
cfoInterfaceLib/CFO_Compiler.cpp |
Adds “Marker #N” annotation to MARKER opcodes in the binary result printout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@rrivera747 I've opened a new pull request, #126, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@rrivera747 I've opened a new pull request, #127, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@rrivera747 I've opened a new pull request, #128, to work on those changes. Once the pull request is ready, I'll request review from you. |
…_MODE_BITS block Co-authored-by: rrivera747 <[email protected]>
…back path Co-authored-by: rrivera747 <[email protected]>
… add andMasks/orMasks param docs Co-authored-by: rrivera747 <[email protected]>
Fix double-parse of expectedDesignVersion in catch fallback path
Fix CompareRunPlanData Doxygen to reflect std::optional semantics
Fix misleading log message in OR_MODE_BITS branch of CompareRunPlanData()
No description provided.