Skip to content

Add MARKER index to printouts for easier tracking of opcodes#125

Merged
rrivera747 merged 16 commits intodevelopfrom
rrivera/betterCFORunPlanPrintoutComments
Mar 9, 2026
Merged

Add MARKER index to printouts for easier tracking of opcodes#125
rrivera747 merged 16 commits intodevelopfrom
rrivera/betterCFORunPlanPrintoutComments

Conversation

@rrivera747
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves run plan debugging output by annotating compiled MARKER opcodes with an incrementing index, and adds additional validation/inspection capabilities around run plan BRAM readback. It also adjusts the DTC firmware version-mismatch message to print a more human-readable expected design date.

Changes:

  • Number MARKER instructions in the compiler’s binary printout for easier opcode tracking.
  • Extend CFO_Registers::CompareRunPlanData to optionally collect AND/OR mode masks during readback/validation (and change its mismatches parameter type).
  • Update DTC design-date mismatch reporting to show a formatted expected design date (with a fallback path).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
dtcInterfaceLib/DTC_Registers.cpp Enhances version mismatch message formatting (expected design date) and adds a fallback message path.
cfoInterfaceLib/CFO_Registers.h Changes CompareRunPlanData signature to use std::optional<std::reference_wrapper<...>> and adds optional mask outputs.
cfoInterfaceLib/CFO_Registers.cpp Implements optional mask extraction during run plan validation and updates mismatch handling for the new optional API.
cfoInterfaceLib/CFO_Compiler.cpp Adds “Marker #N” annotation to MARKER opcodes in the binary result printout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dtcInterfaceLib/DTC_Registers.cpp Outdated
Comment thread dtcInterfaceLib/DTC_Registers.cpp Outdated
Comment thread cfoInterfaceLib/CFO_Registers.h
Comment thread cfoInterfaceLib/CFO_Registers.cpp Outdated
Comment thread cfoInterfaceLib/CFO_Registers.cpp Outdated
@rrivera747 rrivera747 requested a review from eflumerf March 9, 2026 17:41
Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

@rrivera747 I've opened a new pull request, #126, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

@rrivera747 I've opened a new pull request, #127, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 9, 2026

@rrivera747 I've opened a new pull request, #128, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 6 commits March 9, 2026 17:44
… add andMasks/orMasks param docs

Co-authored-by: rrivera747 <[email protected]>
Fix double-parse of expectedDesignVersion in catch fallback path
Fix CompareRunPlanData Doxygen to reflect std::optional semantics
Fix misleading log message in OR_MODE_BITS branch of CompareRunPlanData()
@rrivera747 rrivera747 merged commit e8dc9a5 into develop Mar 9, 2026
9 of 11 checks passed
@rrivera747 rrivera747 deleted the rrivera/betterCFORunPlanPrintoutComments branch March 9, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants