LibWeb: Background parsing and serialization improvements #7050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches the behavior of parsing these longhands directly.
This is required after e937f5d - it went unnoticed until now since the serialization is the same and the relevant code just fell back to it's own defaults which were the same.
We can deduplicate some code by using `assemble_coordinated_value_list`, also moves this to a method in `ComputedProperties` to be in line with other values
Calme1709
force-pushed
the
background-parsing
branch
from
f9d31dc to
dc6e2ee
Compare
AtkinsSJ
requested changes
Dec 8, 2025
Member
AtkinsSJ
left a comment
AtkinsSJ
left a comment
There was a problem hiding this comment.
A tiny nit, otherwise I think this is great. 👍
Updates the `position-serialization.html` test to be 2-valued so that all cases are covered.
Calme1709
force-pushed
the
background-parsing
branch
from
dc6e2ee to
528c07c
Compare
AtkinsSJ
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various improvements to the parsing and serialization of the
backgroundproperty and it's shorthands.Gains us at least 200 WPT tests.
See individual commits for details.