LibWeb: Don't collapse serialized comma separated StyleValueLists

Author: Calme1709

Libraries/LibWeb/CSS/StyleValues/StyleValueList.cpp

@@ -61,7 +61,7 @@ String StyleValueList::to_string(SerializationMode mode) const
     }
 
     auto first_value = m_properties.values.first();
-    if (all_of(m_properties.values, [&](auto const& property) { return property == first_value; }))
+    if (all_of(m_properties.values, [&](auto const& property) { return property == first_value; }) && m_properties.separator != Separator::Comma)
         return first_value->to_string(mode);
 
     StringBuilder builder;

Tests/LibWeb/Text/expected/wpt-import/css/css-anchor-position/parsing/position-try-fallbacks-parsing.txt

@@ -2,8 +2,7 @@ Harness status: OK
 
 Found 43 tests
 
-42 Pass
-1 Fail
+43 Pass
 Pass	e.style['position-try-fallbacks'] = "initial" should set the property value
 Pass	e.style['position-try-fallbacks'] = "inherit" should set the property value
 Pass	e.style['position-try-fallbacks'] = "unset" should set the property value
@@ -13,7 +12,7 @@ Pass	e.style['position-try-fallbacks'] = "flip-block" should set the property va
 Pass	e.style['position-try-fallbacks'] = "flip-block " should set the property value
 Pass	e.style['position-try-fallbacks'] = "flip-start, flip-block" should set the property value
 Pass	e.style['position-try-fallbacks'] = "flip-start flip-inline, flip-block" should set the property value
-Fail	e.style['position-try-fallbacks'] = "flip-start, flip-start" should set the property value
+Pass	e.style['position-try-fallbacks'] = "flip-start, flip-start" should set the property value
 Pass	e.style['position-try-fallbacks'] = "flip-start flip-inline flip-block" should set the property value
 Pass	e.style['position-try-fallbacks'] = "flip-block, --foo" should set the property value
 Pass	e.style['position-try-fallbacks'] = "--bar, flip-block flip-start" should set the property value

Tests/LibWeb/Text/expected/wpt-import/css/css-animations/parsing/animation-duration-computed.txt

@@ -2,14 +2,14 @@ Harness status: OK
 
 Found 15 tests
 
-13 Pass
-2 Fail
+14 Pass
+1 Fail
 Pass	Property animation-duration value '500ms'
 Pass	Property animation-duration value 'calc(2 * 3s)'
 Fail	Property animation-duration value 'calc(10s + (sign(2cqw - 10px) * 5s))'
 Pass	Property animation-duration value '20s, 10s'
 Pass	Property animation-duration value 'auto'
-Fail	Property animation-duration value 'auto, auto'
+Pass	Property animation-duration value 'auto, auto'
 Pass	Resolved value of animation-duration:auto with animation-timeline:auto
 Pass	Resolved value of animation-duration:auto with animation-timeline:auto, auto
 Pass	Resolved value of animation-duration:auto with animation-timeline:--t

Tests/LibWeb/Text/expected/wpt-import/css/css-backgrounds/parsing/background-computed.txt

@@ -2,20 +2,20 @@ Harness status: OK
 
 Found 35 tests
 
-25 Pass
-10 Fail
-Fail	Property background-attachment value 'local'
+30 Pass
+5 Fail
+Pass	Property background-attachment value 'local'
 Pass	Property background-attachment value 'scroll, fixed'
 Pass	Property background-attachment value 'local, fixed, scroll'
 Pass	Property background-attachment value 'local, fixed, scroll, fixed'
-Fail	Property background-clip value 'border-box'
+Pass	Property background-clip value 'border-box'
 Pass	Property background-clip value 'content-box, border-box'
 Pass	Property background-clip value 'border-box, padding-box, content-box'
 Pass	Property background-clip value 'content-box, border-box, padding-box, content-box'
 Pass	Property background-clip value 'content-box, border-box, padding-box'
 Fail	Property background-clip value 'content-box, border-box, border-area'
 Pass	Property background-color value 'rgb(255, 0, 0)'
-Fail	Property background-origin value 'border-box'
+Pass	Property background-origin value 'border-box'
 Pass	Property background-origin value 'content-box, border-box'
 Pass	Property background-origin value 'border-box, padding-box, content-box'
 Pass	Property background-origin value 'content-box, border-box, padding-box, content-box'
@@ -31,11 +31,11 @@ Fail	Property background-position-y value '0.5em'
 Pass	Property background-position-y value '-20%, 10px'
 Pass	Property background-position-y value 'center, top, bottom'
 Fail	Property background-position-y value 'calc(10px - 0.5em), -20%, bottom, 15%'
-Fail	Property background-repeat value 'round'
+Pass	Property background-repeat value 'round'
 Pass	Property background-repeat value 'repeat-x, repeat'
 Pass	Property background-repeat value 'repeat space, round no-repeat, repeat-x'
 Pass	Property background-repeat value 'repeat-y, round no-repeat, repeat-x, repeat'
-Fail	Property background-size value 'contain'
+Pass	Property background-size value 'contain'
 Pass	Property background-size value 'auto 1px, 2% 3%'
 Pass	Property background-size value 'auto 1px, 2% 3%, contain'
 Pass	Property background-size value 'auto 1px, 2% 3%, contain, 7px 8px'

Tests/LibWeb/Text/expected/wpt-import/css/css-masking/parsing/mask-valid.sub.txt

@@ -2,8 +2,8 @@ Harness status: OK
 
 Found 55 tests
 
-40 Pass
-15 Fail
+45 Pass
+10 Fail
 Pass	e.style['mask'] = "none" should set the property value
 Pass	e.style['mask'] = "linear-gradient(to left bottom, red, blue)" should set the property value
 Pass	e.style['mask'] = "linear-gradient(to left bottom, red, blue) luminance" should set the property value
@@ -51,11 +51,11 @@ Fail	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding
 Fail	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-border-source
 Fail	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-border-width
 Pass	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-clip
-Fail	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-composite
+Pass	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-composite
 Pass	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-image
-Fail	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-mode
+Pass	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-mode
 Pass	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-origin
-Fail	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-position
-Fail	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-repeat
-Fail	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-size
+Pass	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-position
+Pass	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-repeat
+Pass	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should set mask-size
 Pass	e.style['mask'] = "none, linear-gradient(to left bottom, red, blue) padding-box" should not set unrelated longhands

Tests/LibWeb/Text/expected/wpt-import/css/css-transitions/parsing/transition-shorthand.txt

@@ -2,21 +2,20 @@ Harness status: OK
 
 Found 18 tests
 
-16 Pass
-2 Fail
+18 Pass
 Pass	e.style['transition'] = "1s -3s cubic-bezier(0, -2, 1, 3) top" should set transition-behavior
 Pass	e.style['transition'] = "1s -3s cubic-bezier(0, -2, 1, 3) top" should set transition-delay
 Pass	e.style['transition'] = "1s -3s cubic-bezier(0, -2, 1, 3) top" should set transition-duration
 Pass	e.style['transition'] = "1s -3s cubic-bezier(0, -2, 1, 3) top" should set transition-property
 Pass	e.style['transition'] = "1s -3s cubic-bezier(0, -2, 1, 3) top" should set transition-timing-function
 Pass	e.style['transition'] = "1s -3s cubic-bezier(0, -2, 1, 3) top" should not set unrelated longhands
-Fail	e.style['transition'] = "1s -3s, cubic-bezier(0, -2, 1, 3) top" should set transition-behavior
+Pass	e.style['transition'] = "1s -3s, cubic-bezier(0, -2, 1, 3) top" should set transition-behavior
 Pass	e.style['transition'] = "1s -3s, cubic-bezier(0, -2, 1, 3) top" should set transition-delay
 Pass	e.style['transition'] = "1s -3s, cubic-bezier(0, -2, 1, 3) top" should set transition-duration
 Pass	e.style['transition'] = "1s -3s, cubic-bezier(0, -2, 1, 3) top" should set transition-property
 Pass	e.style['transition'] = "1s -3s, cubic-bezier(0, -2, 1, 3) top" should set transition-timing-function
 Pass	e.style['transition'] = "1s -3s, cubic-bezier(0, -2, 1, 3) top" should not set unrelated longhands
-Fail	e.style['transition'] = "cubic-bezier(0, -2, 1, 3) top, 1s -3s" should set transition-behavior
+Pass	e.style['transition'] = "cubic-bezier(0, -2, 1, 3) top, 1s -3s" should set transition-behavior
 Pass	e.style['transition'] = "cubic-bezier(0, -2, 1, 3) top, 1s -3s" should set transition-delay
 Pass	e.style['transition'] = "cubic-bezier(0, -2, 1, 3) top, 1s -3s" should set transition-duration
 Pass	e.style['transition'] = "cubic-bezier(0, -2, 1, 3) top, 1s -3s" should set transition-property

Tests/LibWeb/Text/expected/wpt-import/scroll-animations/css/animation-shorthand.txt

@@ -2,26 +2,26 @@ Harness status: OK
 
 Found 27 tests
 
-14 Pass
-13 Fail
+21 Pass
+6 Fail
 Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim" should set the property value
 Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim initial" should not set the property value
 Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim 2000" should not set the property value
 Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim scroll()" should not set the property value
 Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim view()" should not set the property value
 Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim --timeline" should not set the property value
 Pass	Property animation value '1s linear 1s 2 reverse forwards paused anim'
-Fail	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-delay
-Fail	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-direction
-Fail	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-duration
-Fail	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-fill-mode
-Fail	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-iteration-count
+Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-delay
+Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-direction
+Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-duration
+Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-fill-mode
+Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-iteration-count
 Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-name
-Fail	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-play-state
+Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-play-state
 Fail	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-range-end
 Fail	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-range-start
 Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-timeline
-Fail	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-timing-function
+Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should set animation-timing-function
 Pass	e.style['animation'] = "1s linear 1s 2 reverse forwards paused anim1,\n   1s linear 1s 2 reverse forwards paused anim2,\n   1s linear 1s 2 reverse forwards paused anim3" should not set unrelated longhands
 Pass	Animation shorthand can not represent non-initial timelines (specified)
 Pass	Animation shorthand can not represent non-initial timelines (computed)

Tests/LibWeb/Text/expected/wpt-import/scroll-animations/css/animation-timeline-computed.txt

@@ -2,16 +2,15 @@ Harness status: OK
 
 Found 44 tests
 
-42 Pass
-2 Fail
+44 Pass
 Pass	Property animation-timeline value 'initial'
 Pass	Property animation-timeline value 'inherit'
 Pass	Property animation-timeline value 'unset'
 Pass	Property animation-timeline value 'revert'
 Pass	Property animation-timeline value 'auto'
 Pass	Property animation-timeline value 'none'
-Fail	Property animation-timeline value 'auto, auto'
-Fail	Property animation-timeline value 'none, none'
+Pass	Property animation-timeline value 'auto, auto'
+Pass	Property animation-timeline value 'none, none'
 Pass	Property animation-timeline value 'auto, none'
 Pass	Property animation-timeline value 'none, auto'
 Pass	Property animation-timeline value '--test'

Tests/LibWeb/Text/expected/wpt-import/scroll-animations/css/animation-timeline-parsing.txt

@@ -2,16 +2,15 @@ Harness status: OK
 
 Found 69 tests
 
-67 Pass
-2 Fail
+69 Pass
 Pass	e.style['animation-timeline'] = "initial" should set the property value
 Pass	e.style['animation-timeline'] = "inherit" should set the property value
 Pass	e.style['animation-timeline'] = "unset" should set the property value
 Pass	e.style['animation-timeline'] = "revert" should set the property value
 Pass	e.style['animation-timeline'] = "auto" should set the property value
 Pass	e.style['animation-timeline'] = "none" should set the property value
-Fail	e.style['animation-timeline'] = "auto, auto" should set the property value
-Fail	e.style['animation-timeline'] = "none, none" should set the property value
+Pass	e.style['animation-timeline'] = "auto, auto" should set the property value
+Pass	e.style['animation-timeline'] = "none, none" should set the property value
 Pass	e.style['animation-timeline'] = "auto, none" should set the property value
 Pass	e.style['animation-timeline'] = "none, auto" should set the property value
 Pass	e.style['animation-timeline'] = "--test" should set the property value

Tests/LibWeb/Text/expected/wpt-import/scroll-animations/css/scroll-timeline-axis-computed.txt

@@ -2,8 +2,7 @@ Harness status: OK
 
 Found 14 tests
 
-13 Pass
-1 Fail
+14 Pass
 Pass	Property scroll-timeline-axis value 'initial'
 Pass	Property scroll-timeline-axis value 'inherit'
 Pass	Property scroll-timeline-axis value 'unset'
@@ -15,6 +14,6 @@ Pass	Property scroll-timeline-axis value 'x'
 Pass	Property scroll-timeline-axis value 'block, inline'
 Pass	Property scroll-timeline-axis value 'inline, block'
 Pass	Property scroll-timeline-axis value 'block, y, x, inline'
-Fail	Property scroll-timeline-axis value 'inline, inline, inline, inline'
+Pass	Property scroll-timeline-axis value 'inline, inline, inline, inline'
 Pass	The scroll-timeline-axis property shows up in CSSStyleDeclaration enumeration
 Pass	The scroll-timeline-axis property shows up in CSSStyleDeclaration.cssText