Skip to content

Fixes for metadata credential fetching #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
contradict wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes for metadata credential fetching #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28ecc02
Fix MetadataCredentials for new HTTP
russelhowe Sep 3, 2020
09286ba
Fix parsing of Content-Type header
russelhowe Sep 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/api/api.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,8 @@ function execute(session::GoogleSession, resource::APIResource, method::APIMetho
# https://github.com/JuliaWeb/HTTP.jl/blob/master/src/Messages.jl#L166
for (key, value) in res.headers
if key=="Content-Type"
if value=="application/json"
content_type = split(value, ";")[1]
if content_type=="application/json"
for (k2, v2) in res.headers
if k2=="Content-Length" && v2=="0"
return HTTP.nobody
Expand Down
2 changes: 1 addition & 1 deletion src/credentials.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ function Base.get(credentials::MetadataCredentials, path::AbstractString; contex
if HTTP.Messages.status(res) != 200
throw(CredentialError("Unable to obtain credentials from metadata server"))
end
String(res.data)
String(res.body)
end

"""
Expand Down