Fixes for metadata credential fetching#32
Fixes for metadata credential fetching#32contradict wants to merge 2 commits intoJuliaCloud:masterfrom
Conversation
.data -> .body
There are now two values in one header:
application/json; charset=utf-8
Split on the semicolon and check the first part.
|
This package doesn't look like it gets too much attention sadly. When I have some spare time I can look into the CI error and fix it. Would you mind possibly adding some tests to this? Although looking at what exists currently there doesn't seem to be much there. |
|
Hi Matt, I am no longer using GCP and therefore am no longer maintaining this package. If you'd like to fork this repo I'll link to the fork from here and archive this repo. |
I think it can continue to live in the JuliaCloud org, it seems like an appropriate place. |
|
I can confirm that this PR is still necessary for Thanks for this great package (and PR :-)) ! |
The first change is for a change in the Julia HTTP library,
datais nowbody.The second is for a change it the Google API, the format of the
Content-Typeheader has changed.With these two changes,
MetadataCredentialsworks on GCE instances.