-
Notifications
You must be signed in to change notification settings - Fork 6
121 feature non atlas centric preprocessing pipeline #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
121 feature non atlas centric preprocessing pipeline #139
Conversation
Improve docstrings/ exception message
Make niftyreg compatible with single path instead of list
…f github.com:BrainLesion/preprocessing into 121-feature-non-atlas-centric-preprocessing-pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the preprocessing pipeline to support multiple processing paradigms by introducing a non-atlas-centric approach alongside the existing atlas-centric preprocessing. The changes create a more modular architecture with specialized preprocessors for different use cases.
- Implementation of a new native space preprocessing pipeline that operates without atlas registration
- Refactoring of the existing preprocessor into separate atlas-centric and base preprocessor classes
- Addition of enhanced defacing capabilities with optional atlas registration for improved performance
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| brainles_preprocessing/preprocessor/preprocessor.py | Introduces BasePreprocessor abstract class with common preprocessing functionality |
| brainles_preprocessing/preprocessor/atlas_centric_preprocessor.py | Refactored atlas-centric preprocessor inheriting from BasePreprocessor |
| brainles_preprocessing/preprocessor/native_space_preprocessor.py | New native space preprocessor for processing without atlas registration |
| brainles_preprocessing/preprocessor/init.py | Module initialization with backward compatibility for deprecated Preprocessor class |
| brainles_preprocessing/modality.py | Enhanced modality classes with improved defacing support and flexible input handling |
| brainles_preprocessing/defacing/quickshear/quickshear.py | Enhanced QuickshearDefacer with configurable atlas registration |
| tests/test_preprocessor.py | Updated tests to use new AtlasCentricPreprocessor class |
| example/example_atlas_centric_preprocessor.py | New example demonstrating atlas-centric preprocessing |
| example/example_native_space_preprocessor.py | New example demonstrating native space preprocessing |
| example/example_modality_centric_preprocessor.py | Removed outdated example file |
Comments suppressed due to low confidence (2)
brainles_preprocessing/preprocessor/atlas_centric_preprocessor.py:209
- This comment and the following code block (lines 209-211) appear to be duplicated from the base class. Consider removing this duplication since the base class already handles this logic in the run_coregistration method.
transformation_matrix = self.center_modality.register(
example/example_native_space_preprocessor.py:93
- The output directory name 'mni_native_space_preprocessed_{subject}' is misleading since this is native space preprocessing, not MNI space. Consider renaming to 'native_space_preprocessed_{subject}'.
output_dir=Path(
copilot is right Co-authored-by: Copilot <[email protected]>
…f github.com:BrainLesion/preprocessing into 121-feature-non-atlas-centric-preprocessing-pipeline
|
/format |
|
🤖 I will now format your code with black. Check the status here. |
No description provided.