Skip to content

Conversation

@MarcelRosier
Copy link
Collaborator

No description provided.

@MarcelRosier MarcelRosier linked an issue Jul 14, 2025 that may be closed by this pull request
@MarcelRosier MarcelRosier requested a review from neuronflow July 14, 2025 17:23
@MarcelRosier MarcelRosier self-assigned this Jul 14, 2025
@MarcelRosier MarcelRosier marked this pull request as ready for review July 15, 2025 16:11
Copilot AI review requested due to automatic review settings July 15, 2025 16:11

This comment was marked as outdated.

@neuronflow neuronflow requested a review from Copilot July 15, 2025 17:27

This comment was marked as outdated.

MarcelRosier and others added 3 commits July 16, 2025 09:55
Make niftyreg compatible with single path instead of list
…f github.com:BrainLesion/preprocessing into 121-feature-non-atlas-centric-preprocessing-pipeline
@neuronflow neuronflow requested a review from Copilot July 16, 2025 08:47

This comment was marked as outdated.

@neuronflow neuronflow requested a review from Copilot July 17, 2025 09:45
@neuronflow neuronflow enabled auto-merge July 17, 2025 09:46

This comment was marked as outdated.

@neuronflow neuronflow requested a review from Copilot July 17, 2025 09:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the preprocessing pipeline to support multiple processing paradigms by introducing a non-atlas-centric approach alongside the existing atlas-centric preprocessing. The changes create a more modular architecture with specialized preprocessors for different use cases.

  • Implementation of a new native space preprocessing pipeline that operates without atlas registration
  • Refactoring of the existing preprocessor into separate atlas-centric and base preprocessor classes
  • Addition of enhanced defacing capabilities with optional atlas registration for improved performance

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
brainles_preprocessing/preprocessor/preprocessor.py Introduces BasePreprocessor abstract class with common preprocessing functionality
brainles_preprocessing/preprocessor/atlas_centric_preprocessor.py Refactored atlas-centric preprocessor inheriting from BasePreprocessor
brainles_preprocessing/preprocessor/native_space_preprocessor.py New native space preprocessor for processing without atlas registration
brainles_preprocessing/preprocessor/init.py Module initialization with backward compatibility for deprecated Preprocessor class
brainles_preprocessing/modality.py Enhanced modality classes with improved defacing support and flexible input handling
brainles_preprocessing/defacing/quickshear/quickshear.py Enhanced QuickshearDefacer with configurable atlas registration
tests/test_preprocessor.py Updated tests to use new AtlasCentricPreprocessor class
example/example_atlas_centric_preprocessor.py New example demonstrating atlas-centric preprocessing
example/example_native_space_preprocessor.py New example demonstrating native space preprocessing
example/example_modality_centric_preprocessor.py Removed outdated example file
Comments suppressed due to low confidence (2)

brainles_preprocessing/preprocessor/atlas_centric_preprocessor.py:209

  • This comment and the following code block (lines 209-211) appear to be duplicated from the base class. Consider removing this duplication since the base class already handles this logic in the run_coregistration method.
        transformation_matrix = self.center_modality.register(

example/example_native_space_preprocessor.py:93

  • The output directory name 'mni_native_space_preprocessed_{subject}' is misleading since this is native space preprocessing, not MNI space. Consider renaming to 'native_space_preprocessed_{subject}'.
        output_dir=Path(

neuronflow and others added 3 commits July 17, 2025 11:55
copilot is right

Co-authored-by: Copilot <[email protected]>
…f github.com:BrainLesion/preprocessing into 121-feature-non-atlas-centric-preprocessing-pipeline
@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jul 17, 2025

🤖 Code Formatting Reminder

Hello there! 👋 It looks like the code in this pull request might benefit from some formatting improvements.
Fix the issues locally or use our auto format action by commenting /format on this PR!

Code style: black

@neuronflow
Copy link
Collaborator

/format

@brainless-bot
Copy link
Contributor

brainless-bot bot commented Jul 17, 2025

🤖 I will now format your code with black. Check the status here.

@neuronflow neuronflow merged commit ebf22e1 into main Jul 17, 2025
4 checks passed
@neuronflow neuronflow deleted the 121-feature-non-atlas-centric-preprocessing-pipeline branch July 17, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] non-atlas centric preprocessing pipeline

3 participants