Skip to content

Rewrite cookie generation to use Web.Cookie and generate spec conforming cookie headers#47

Open
nmk wants to merge 1 commit intozohl:masterfrom
nmk:master
Open

Rewrite cookie generation to use Web.Cookie and generate spec conforming cookie headers#47
nmk wants to merge 1 commit intozohl:masterfrom
nmk:master

Conversation

@nmk
Copy link
Copy Markdown

@nmk nmk commented Feb 26, 2018

Currently, servant-auth-cookie generates invalid cookies which fail on some browsers. The error is in the rendering of the previously available acsCookieFlags field. It resulted in cookies which look like
name=value;HttpOnly=;Secure=;SameSite. This failed to set a cookie for me on Chrome 64.0.3282.186 on OS X. Firefox and Safari seem to be more lenient in their cookie parsing and parsed the cookie successfully. In any case, if I read the spec correctly, the above should be name=value;HttpOnly;Secure;SameSite (not the missing equals signs).

As this package already leverages Web.Cookie from the cookie package, I rewrote the rendering code to use the provided functions, which results in spec conforming cookies. This required the addition of specific fields for the HttpOnly, Secure and SameSite options in AuthCookieSettings type. I have added the fields in the default instance, so the tests continue to run. I am not sure what to do with the version number though - I will leave it up to you, as this might break user code if they were using the acsCookieFlags field.

- Format cookie flags correctly
- Bump stack resolver for cookie-0.4.3
@kristoff3r
Copy link
Copy Markdown

This is much better than my pull request, +1

@afcady
Copy link
Copy Markdown

afcady commented Sep 1, 2018

So why wasn't this merged? Is this package abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants