Skip to content

One tick KScan wait on RP2350 as for RP2040#3255

Open
peterjc wants to merge 2 commits intozmkfirmware:mainfrom
peterjc:rp2350_kscan_wait
Open

One tick KScan wait on RP2350 as for RP2040#3255
peterjc wants to merge 2 commits intozmkfirmware:mainfrom
peterjc:rp2350_kscan_wait

Conversation

@peterjc
Copy link
Contributor

@peterjc peterjc commented Feb 23, 2026

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

Based on an observation made on the ZMK Discord, I tested this change on my diode-free Slump52 keyboard using active low with open drain (a recent change which seems to be working fine with the RP2040).

RP2350 on Base ZMK - single key presses worked, but some like Qwerty M and L triggered a nearby key as well.

RP2350 With this change - all single key presses seemed to work

Test built here: peterjc/zmk-keyboard-graph-theory@630b77f

@peterjc peterjc requested a review from a team as a code owner February 23, 2026 22:39
config ZMK_KSCAN_MATRIX_WAIT_BETWEEN_OUTPUTS
int "Ticks to wait between each output when scanning"
default 1 if SOC_RP2040
default 1 if SOC_RP2040 || SOC_RP2350A_M33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a family we can key on for all of RP2350, so we catch this properly once the Hazard stuff is in, or folks use the B variants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'd use the series for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change applied to the branch and PR, not tested yet.

@petejohanson petejohanson added this to the v0.4.0 milestone Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants