One tick KScan wait on RP2350 as for RP2040#3255
Open
peterjc wants to merge 2 commits intozmkfirmware:mainfrom
Open
One tick KScan wait on RP2350 as for RP2040#3255peterjc wants to merge 2 commits intozmkfirmware:mainfrom
peterjc wants to merge 2 commits intozmkfirmware:mainfrom
Conversation
petejohanson
requested changes
Feb 27, 2026
app/module/drivers/kscan/Kconfig
Outdated
| config ZMK_KSCAN_MATRIX_WAIT_BETWEEN_OUTPUTS | ||
| int "Ticks to wait between each output when scanning" | ||
| default 1 if SOC_RP2040 | ||
| default 1 if SOC_RP2040 || SOC_RP2350A_M33 |
Contributor
There was a problem hiding this comment.
Is there a family we can key on for all of RP2350, so we catch this properly once the Hazard stuff is in, or folks use the B variants?
Contributor
Author
There was a problem hiding this comment.
I don't know - I did wonder about having the logical-or include the Hazard form too.
Maybe SOC_SERIES_RP2350 would do it? See https://github.com/zmkfirmware/zephyr/blob/v4.1.0%2Bzmk-fixes/soc/raspberrypi/rpi_pico/rp2350/Kconfig or https://github.com/zmkfirmware/zephyr/blob/v4.1.0%2Bzmk-fixes/soc/raspberrypi/rpi_pico/rp2350/Kconfig.soc
Contributor
There was a problem hiding this comment.
Yes, I'd use the series for this.
Contributor
Author
There was a problem hiding this comment.
Change applied to the branch and PR, not tested yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR check-list
Based on an observation made on the ZMK Discord, I tested this change on my diode-free Slump52 keyboard using active low with open drain (a recent change which seems to be working fine with the RP2040).
RP2350 on Base ZMK - single key presses worked, but some like Qwerty M and L triggered a nearby key as well.
RP2350 With this change - all single key presses seemed to work
Test built here: peterjc/zmk-keyboard-graph-theory@630b77f