Use "Faster Subgroup Checks for BLS12-381" for is_torsion_free#80
Closed
zanebeckwith wants to merge 1 commit intozkcrypto:mainfrom
Closed
Use "Faster Subgroup Checks for BLS12-381" for is_torsion_free#80zanebeckwith wants to merge 1 commit intozkcrypto:mainfrom
is_torsion_free#80zanebeckwith wants to merge 1 commit intozkcrypto:mainfrom
Conversation
Contributor
|
Closing in favor of #83. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses @ebfull's method for faster subgroup checks
I didn't know if maybe there's a specific reason you all aren't already using these methods here. If so, sorry for the noise!
On my Core i7 Macbook Pro, the "G1Affine subgroup check" benchmark takes:
mainSimilarly, the "G2Affine subgroup check" benchmark takes:
main