Replacing imgui to c homemade wrapper by cimgui#65
Open
tonitch wants to merge 16 commits intozig-gamedev:mainfrom
Open
Replacing imgui to c homemade wrapper by cimgui#65tonitch wants to merge 16 commits intozig-gamedev:mainfrom
tonitch wants to merge 16 commits intozig-gamedev:mainfrom
Conversation
I'm tired...
added 6 commits
September 1, 2025 22:12
there muse be a lot of problem now but it requires test. it's also way faster
Contributor
Author
|
I believe this branch is now in a usable state. Also, this branch now uses imgui 1.92.1 which is what #51 is doing as well. Maybe @kcbanner you could give me your opinion? Currently, I haven't really added any new features of this imgui versions. So your input would be great. I also added some zig 0.5.1 compatibility that was probably forgotten. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As previously discussed on discord, switching to using cimgui instead of wrapping every function of imgui manually might be a good idea.
By doing so, updating to the last imgui version should only be a matter of updating the commit hash in build.zig.zon while every single method is already wrapped and can be exposed to the users that would need really specific needs without having to make a pr.
Currently, this PR is not in a usable state at all. I put it here as a WIP (it compiles tho) so that if people want to have a look and give opinions they are welcome to do so.
My current thought is, to go in two steps to avoid defacing the whole project.
Any comments are welcome. I'll work on that at my own pace, as I might not have so much time.