Fix README.md: make examples compile and make more consistent#49
Merged
hazeycode merged 1 commit intozig-gamedev:mainfrom Feb 28, 2026
Merged
Fix README.md: make examples compile and make more consistent#49hazeycode merged 1 commit intozig-gamedev:mainfrom
hazeycode merged 1 commit intozig-gamedev:mainfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to check and test the README.md more in depth and found several issues so i fixed them.
In my previous commit i missed that vulkan integration example has the problem with non debug builds (mentioned in here Wont compile with anything but debug #35) and added .target and .optimize fields to fix that.
Vulkan headers line was missing a second parameter
Cosmetic changes
I changed the Vulkan dependency name from "vulkan_zig" to "vulkan" as that's how it appears in build.zig.zon by default after fetching.
I changed the first build.zig example to be more self contained and copy-paste friendly
I made the Vulkan integration example more concise and more similar to the original build.zig mentioned above so that it can be updated with minimal effort.